Giter VIP home page Giter VIP logo

Comments (35)

denkensk avatar denkensk commented on June 3, 2024 2

User guide is also needed.

from kueue.

ArangoGutierrez avatar ArangoGutierrez commented on June 3, 2024 1

I would add #52 to that checklist

from kueue.

ahg-g avatar ahg-g commented on June 3, 2024 1

Yeah, I submitted a proposal to present it at KubeCon the general event, but will also be discussing it in the colo event.

from kueue.

ArangoGutierrez avatar ArangoGutierrez commented on June 3, 2024 1

@alculquicondor can you pin this? so is easier to find

from kueue.

ahg-g avatar ahg-g commented on June 3, 2024 1

I think we need to add #4 to the list, I will work on that.

from kueue.

ArangoGutierrez avatar ArangoGutierrez commented on June 3, 2024 1

we have an image!!!
gcr.io/k8s-staging-kueue/kueue:devel

[eduardo@fedora-workstation kueue]$ skopeo list-tags docker://gcr.io/k8s-staging-kueue/kueue
{
    "Repository": "gcr.io/k8s-staging-kueue/kueue",
    "Tags": [
        "devel"
    ]
}

Prow job: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-kueue-push-images/1502394011774619648

from kueue.

ahg-g avatar ahg-g commented on June 3, 2024 1

Before the first release we need to ignore jobs with queue name not set; this is important so users are not surprised that their existing running jobs get suspended when they first try Kueue.

We will add a flag to ComponentConfig to disable this behavior, and a namespace selector to select which namespaces the job-controller will take over. We can do that in the next release.

from kueue.

alculquicondor avatar alculquicondor commented on June 3, 2024

/kind feature

from kueue.

alculquicondor avatar alculquicondor commented on June 3, 2024

cc @ahg-g @ArangoGutierrez @denkensk thoughts? Did I miss something?

from kueue.

ArangoGutierrez avatar ArangoGutierrez commented on June 3, 2024

Ohhhh that smell of a new release in the air.... uh lala

from kueue.

ArangoGutierrez avatar ArangoGutierrez commented on June 3, 2024

something we can quickly implement as well could be github-pages for small documentation? (I can volunteer have done that for other sigs)

from kueue.

denkensk avatar denkensk commented on June 3, 2024

#14 Is there any progress on this? @ArangoGutierrez

from kueue.

ArangoGutierrez avatar ArangoGutierrez commented on June 3, 2024

we agree to wait for klog/v3 no?

But this is changing soon https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3077-contextual-logging

In the meantime, if we stick with logr for now, I think it will be easier to switch to klog (v3?) once it supports contextual logging.

from kueue.

ahg-g avatar ahg-g commented on June 3, 2024

I don't think we should block the first release on #62, ceiling is workable for a 0.0.1 version .

from kueue.

ArangoGutierrez avatar ArangoGutierrez commented on June 3, 2024

can we set KubeCon EU as dead line for this? would be a nice thing to achieve

from kueue.

denkensk avatar denkensk commented on June 3, 2024

Great

from kueue.

alculquicondor avatar alculquicondor commented on June 3, 2024

I think we should be able to have something sooner. But kubecon EU is a nice hard deadline :) Added to the description.

I don't think we should block the first release on #62, ceiling is workable for a 0.0.1 version .

I think it is indeed usable, but migrating to weights from the first version will avoid one breaking change. Sure... they are alpha APIs, but if we can avoid it, it would be great. Moved to nice-to-have.

from kueue.

ahg-g avatar ahg-g commented on June 3, 2024

also #91

from kueue.

ArangoGutierrez avatar ArangoGutierrez commented on June 3, 2024

check mark Publish image https://github.com/kubernetes-sigs/kueue/issues/52

from kueue.

ArangoGutierrez avatar ArangoGutierrez commented on June 3, 2024

Check Single heap per Capacity https://github.com/kubernetes-sigs/kueue/issues/87

from kueue.

ArangoGutierrez avatar ArangoGutierrez commented on June 3, 2024

CHeckMark -> Queue status https://github.com/kubernetes-sigs/kueue/issues/5

from kueue.

ArangoGutierrez avatar ArangoGutierrez commented on June 3, 2024

Checkmark Event for unschedulable workloads #91

from kueue.

ArangoGutierrez avatar ArangoGutierrez commented on June 3, 2024

checkmark User guide https://github.com/kubernetes-sigs/kueue/issues/64

from kueue.

alculquicondor avatar alculquicondor commented on June 3, 2024

@ahg-g @denkensk @ArangoGutierrez PTAL at the draft for release notes in the issue description.

from kueue.

ArangoGutierrez avatar ArangoGutierrez commented on June 3, 2024

can we use https://github.com/kubernetes-sigs/kueue/blob/main/.github/ISSUE_TEMPLATE/NEW_RELEASE.md ?

from kueue.

alculquicondor avatar alculquicondor commented on June 3, 2024

Opened #197

from kueue.

ahg-g avatar ahg-g commented on June 3, 2024

A couple of other renames we should do:

  1. cq.requestableResources -> resources
  2. cq.flavor.resourceFlavor -> cq.flavor.name

from kueue.

alculquicondor avatar alculquicondor commented on June 3, 2024

sgtm, can you open an issue and/or PR?

from kueue.

ahg-g avatar ahg-g commented on June 3, 2024

I will address the two comments above once the multiple api groups pr merges

from kueue.

alculquicondor avatar alculquicondor commented on June 3, 2024

A couple of other renames we should do:

  1. cq.requestableResources -> resources
  2. cq.flavor.resourceFlavor -> cq.flavor.name

+1 to both

from kueue.

ahg-g avatar ahg-g commented on June 3, 2024

#205 disables reconciling jobs with no queue name set.

from kueue.

ahg-g avatar ahg-g commented on June 3, 2024

and #206 for renaming requestableResources in the api.

from kueue.

ahg-g avatar ahg-g commented on June 3, 2024

and #207 for component config

from kueue.

alculquicondor avatar alculquicondor commented on June 3, 2024

All items are complete. We probably leave the nice-to-have issues for the next release.

/close

from kueue.

k8s-ci-robot avatar k8s-ci-robot commented on June 3, 2024

@alculquicondor: Closing this issue.

In response to this:

All items are complete. We probably leave the nice-to-have issues for the next release.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from kueue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.