Giter VIP home page Giter VIP logo

Comments (17)

ahg-g avatar ahg-g commented on June 2, 2024 1

@ArangoGutierrez for this one, I guess we could simply create an event in the same place where you are updating the conditions, right?

from kueue.

ArangoGutierrez avatar ArangoGutierrez commented on June 2, 2024 1

Yes, i started working on this late Friday, planning on opening PR tomorrow Monday.

from kueue.

alculquicondor avatar alculquicondor commented on June 2, 2024

Let's block this on #87

from kueue.

alculquicondor avatar alculquicondor commented on June 2, 2024

Actually, it shouldn't conflict much.

Related: #102

from kueue.

ahg-g avatar ahg-g commented on June 2, 2024

/help

from kueue.

k8s-ci-robot avatar k8s-ci-robot commented on June 2, 2024

@ahg-g:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from kueue.

ahg-g avatar ahg-g commented on June 2, 2024

/good-first-issue

from kueue.

k8s-ci-robot avatar k8s-ci-robot commented on June 2, 2024

@ahg-g:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from kueue.

uroy-personal avatar uroy-personal commented on June 2, 2024

Hi @ahg-g,

I am interested on working on this issue if it is not being worked upon at the moment. Please let me know if I can assign this issue to myself.
Thanks,
Have a nice Day..

from kueue.

alculquicondor avatar alculquicondor commented on June 2, 2024

if it's not assigned and it's marked as "good first issue" it's free to take :)

from kueue.

uroy-personal avatar uroy-personal commented on June 2, 2024

marked

Thanks @alculquicondor..

from kueue.

uroy-personal avatar uroy-personal commented on June 2, 2024

/assign

from kueue.

ahg-g avatar ahg-g commented on June 2, 2024

This is great, thanks @uroy-personal , please let us know if you need help; are you planning on working on it soon?

from kueue.

uroy-personal avatar uroy-personal commented on June 2, 2024

This is great, thanks @uroy-personal , please let us know if you need help; are you planning on working on it soon?

Yes of course. I will start later today. Will keep you posted on progress and will reach out to you on slack if I get any queries. Thanks for providing me the opportunity to be part of this project.

from kueue.

ArangoGutierrez avatar ArangoGutierrez commented on June 2, 2024

yup, the wrapper func looks like the right place

from kueue.

ArangoGutierrez avatar ArangoGutierrez commented on June 2, 2024

/assign

from kueue.

ahg-g avatar ahg-g commented on June 2, 2024

@ArangoGutierrez I assume you will be working on this, correct?

from kueue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.