Giter VIP home page Giter VIP logo

Comments (13)

bickfordb avatar bickfordb commented on May 19, 2024 2

Maybe this could mostly be accomplished by allowing the name field to be a regular expression?

from kustomize.

Liujingfang1 avatar Liujingfang1 commented on May 19, 2024

The idea in #122 can help this. If kustomize provides to way to declare a user defined transformation and use that, this transformation can will be applied during kustomize build. To patch multiple objects with one patch, you only need to provide a proper transformer.

from kustomize.

itsnagaraj avatar itsnagaraj commented on May 19, 2024

I love this idea/feature as well. I work on mono-repo project where we manage kubernetes spec for 30 microservice. We have templated everything in spec so that adding new service is a breeze. Templating logic is so complicated we have decided to move away from that approach and start evaluating tools like Kompose. Kompose doesn't fit for the project structure as the selector for deployment works by metadata->name and I will end up overlays for each service and lots of duplication

from kustomize.

nhoughto avatar nhoughto commented on May 19, 2024

Does seem to make sense to be able to target resources with something other than name, label perhaps.

The README relates kustomize to sed it's like sed, in that it emits editted text., which is a great comparison, and is how i want it to work, but unless i'm missing something I can't use arbitrary values to target things for overlays? Name, label, or even just type would be great. I'd like to be as generic as possible.

from kustomize.

Liujingfang1 avatar Liujingfang1 commented on May 19, 2024

Regardless of the patches or transformation. The original request is to ask an easy way to update the container image name wherever it is used.

from kustomize.

bickfordb avatar bickfordb commented on May 19, 2024

@Liujingfang1 actually, I was concerned about transforming/sharing multiple pod values, not just the container name.

from kustomize.

Liujingfang1 avatar Liujingfang1 commented on May 19, 2024

@bickfordb What pod values you need to update? Can you give an example?

from kustomize.

pwittrock avatar pwittrock commented on May 19, 2024

I think there are 2 issues here:

  • Write patches that can match label / names
  • Support a simple way to update images without a patch

from kustomize.

Liujingfang1 avatar Liujingfang1 commented on May 19, 2024

I think there are 2 issues here:

Write patches that can match label / names

This can be solved by #122

Support a simple way to update images without a patch

This is supported by imageTags. See the imageTags demo

from kustomize.

bickfordb avatar bickfordb commented on May 19, 2024

@Liujingfang1 are you particularly opposed to allowing patches to match on a label based selector?

from kustomize.

yuya-takeyama avatar yuya-takeyama commented on May 19, 2024

This is supported by imageTags. See the imageTags demo

The link is dead:
https://github.com/kubernetes-sigs/kustomize/blob/master/examples/imageTags.md

from kustomize.

monopole avatar monopole commented on May 19, 2024

@bickfordb This issue was closed because of it's name and the introduction of set imageTag command.

The notion of applying patches guided by a label based selection could certainly be opened as a new issue.

As could the If you have time, please look at the conversation in #300 (less so the one in #169) and feel free to comment. It's closely related so some of what you mentioned above w/r (outside the scope of changing only the image tag).

from kustomize.

bickfordb avatar bickfordb commented on May 19, 2024

👍

from kustomize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.