What happened : We upgraded the prow components from

My first thought is that maybe <a class="issue-link js-issue-link" data-error-text="Fa

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

ref. <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-i

[BUG] CC multiple people does not work anymore about prow HOT 13 CLOSED

gregpavl commented on July 28, 2024

[BUG] CC multiple people does not work anymore

from prow.

Comments (13)

droslean commented on July 28, 2024 1

My first thought is that maybe #164 is related. @Okabe-Junya Any ideas?

from prow.

smg247 commented on July 28, 2024 1

I see that this feature was attempted and then reverted, but I am skeptical that a change here is necessary at all. I have always been able to use cc with a github team. For example, I use /cc @openshift/test-platform often in our installation, and it ccs the team itself rather than the individual members.

If this feature is attempted again, it should at least be behind a configuration so that installations that would like to retain the existing behavior are able to do so.

from prow.

Okabe-Junya commented on July 28, 2024

Upon checking the git history, it seems that the only change to the assign plugin after the migration to k-sigs/prow was my PR(#164).

I apologize if this caused any inconvenience. I have created a PR to revert #164, which might serve as a useful workaround for now.

from prow.

Okabe-Junya commented on July 28, 2024

/kind bug

from prow.

Okabe-Junya commented on July 28, 2024

What I don't understand is that while my PR was merged on May 28, the tag where the bug happened is v20240515. (Is this tag based on the date the image was built?)

Moreover, my PR only changed the behavior for teams, so it shouldn't have affected the /cc Alice Bob ... format command at all. All elements should result in the isTeamLogin function returning false, meaning that simply users[login] = add would be executed.

prow/pkg/plugins/assign/assign.go

Lines 137 to 148 in 79d27b6

 for _, login := range parseLogins(re[2]) { 

 if isTeamLogin(login) { 

 teamMembers, err := h.gc.ListTeamMembersBySlug(org, login, "all") 

 if err != nil { 

 return fmt.Errorf("failed to list team members: %w", err) 

 } 

 for _, member := range teamMembers { 

 users[member.Login] = add 

 } 

 } else { 

 users[login] = add 

 }

from prow.

Okabe-Junya commented on July 28, 2024

I am not sure if this will directly resolve the bug, but I did find one bug. I misunderstood the signature of the ListTeamMembersBySlug function and made an incorrect call. I have created a PR to fix this - #206

from prow.

Okabe-Junya commented on July 28, 2024

/assign

from prow.

Okabe-Junya commented on July 28, 2024

@droslean

I want to check the image tag. It looks like the tag is from before my PR was merged. Do you have any idea what could be the cause?

ref. #204 (comment)

What I don't understand is that while my PR was merged on May 28, the tag where the bug happened is v20240515. (Is this tag based on the date the image was built?)

from prow.

Okabe-Junya commented on July 28, 2024

@gregpavl

I created and merged the revert PR - this issue might be resolved in the latest Prow image.

If possible, please let me know if this bug is resolved, thanks!

from prow.

Okabe-Junya commented on July 28, 2024

ref. #145 (comment)

I see that this feature was attempted and then reverted, but I am skeptical that a change here is necessary at all. I have always been able to use cc with a github team. For example, I use /cc @openshift/test-platform often in our installation, and it ccs the team itself rather than the individual members. This had stopped working for awhile, and I see now it was due to the bug described in #204.

I think the reason why issue #145 was created is that the command in the format cc @org-name/team-name could not be executed. Even after checking the source code, it appears that mentions in the format containing "/" are not handled.

prow/pkg/plugins/assign/assign.go

Lines 122 to 131 in e49eac6

 for _, re := range matches { 

 add := re[1] != "un" // un<cmd> == !add 

 if re[2] == "" { 

 users[e.User.Login] = add 

 } else { 

 for _, login := range parseLogins(re[2]) { 

 users[login] = add 

 } 

 } 

 }

Meaning, isn't it just using GitHub's feature to mention, rather than a command from prow?

from prow.

droslean commented on July 28, 2024

/close

from prow.

k8s-ci-robot commented on July 28, 2024

@droslean: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

from prow.

Okabe-Junya commented on July 28, 2024

I don't think this discussion has been resolved yet, though...

#204 (comment)

from prow.

[BUG] CC multiple people does not work anymore about prow HOT 13 CLOSED

Comments (13)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	for _, login := range parseLogins(re[2]) {
	if isTeamLogin(login) {
	teamMembers, err := h.gc.ListTeamMembersBySlug(org, login, "all")
	if err != nil {
	return fmt.Errorf("failed to list team members: %w", err)
	}
	for _, member := range teamMembers {
	users[member.Login] = add
	}
	} else {
	users[login] = add
	}

	for _, re := range matches {
	add := re[1] != "un" // un<cmd> == !add
	if re[2] == "" {
	users[e.User.Login] = add
	} else {
	for _, login := range parseLogins(re[2]) {
	users[login] = add
	}
	}
	}