Giter VIP home page Giter VIP logo

Comments (14)

mwielgus avatar mwielgus commented on May 19, 2024 4

@mrcrgl Absolutely, please send us a PR.

from autoscaler.

kylegato avatar kylegato commented on May 19, 2024 1

@mrcrgl It looks like some of the work for the on-demand pricing was started here:

https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/ec2_instance_types/gen.go

Because pricing can be dependent on your region and account features, this seems to cover some of that, but it needs to be fixed to work with the current API response formats.

Support for detecting the GPU field and instance types would also be nice for that.

I think getting the spot prices from the spot price history API makes perfect sense.

from autoscaler.

mrcrgl avatar mrcrgl commented on May 19, 2024

We're interested in this feature. Are contributions welcome?

from autoscaler.

mrcrgl avatar mrcrgl commented on May 19, 2024

@mwielgus Ok. I'll start on it. Is it fine for you guys to evaluate the spot prices on demand via the spot price history api? I also tend to load the price list on demand as well (with caching).

from autoscaler.

mrcrgl avatar mrcrgl commented on May 19, 2024

I've worked on it. I'll test these feature within the next few days on one of our clusters.
Does this change work for you guys?

from autoscaler.

mrcrgl avatar mrcrgl commented on May 19, 2024

@mwielgus PTAL #486

from autoscaler.

fejta-bot avatar fejta-bot commented on May 19, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from autoscaler.

fejta-bot avatar fejta-bot commented on May 19, 2024

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

from autoscaler.

patrickf55places avatar patrickf55places commented on May 19, 2024

The lifecycle/rotten label should be removed; the PR is still active.

from autoscaler.

aleksandra-malinowska avatar aleksandra-malinowska commented on May 19, 2024

/remove-lifecycle stale

from autoscaler.

fejta-bot avatar fejta-bot commented on May 19, 2024

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

from autoscaler.

bskiba avatar bskiba commented on May 19, 2024

/reopen

from autoscaler.

k8s-ci-robot avatar k8s-ci-robot commented on May 19, 2024

@bskiba: you can't re-open an issue/PR unless you authored it or you are assigned to it.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from autoscaler.

kesor avatar kesor commented on May 19, 2024

@mwielgus @mumoshu can you reopen this? or if this has been implemented, link the issue that has this merged?

from autoscaler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.