Giter VIP home page Giter VIP logo

Comments (11)

aoxn avatar aoxn commented on June 30, 2024

/assign @andrewsykim

from cloud-provider.

fejta-bot avatar fejta-bot commented on June 30, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from cloud-provider.

andrewsykim avatar andrewsykim commented on June 30, 2024

/remove-lifecycle stale

from cloud-provider.

andrewsykim avatar andrewsykim commented on June 30, 2024

@aoxn what's the use-case for multiple route tables?

from cloud-provider.

aoxn avatar aoxn commented on June 30, 2024

The background is that CCM goes wrong when user has multiple routetalbes under their VPC. Because the default ccm behavior is to write the 0th route table which would not be the target(route table).

Alibaba Cloud use a self defined controller extended cloudprovider interface to solve this issue for now. It might be better to solve it in cloudporivder interface level as other provider may face the same problems.

from cloud-provider.

andrewsykim avatar andrewsykim commented on June 30, 2024

ping @aoxn what's the status of this for v1.17?

from cloud-provider.

fejta-bot avatar fejta-bot commented on June 30, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from cloud-provider.

aoxn avatar aoxn commented on June 30, 2024

@andrewsykim I am afraid a new Interface would be add in order to support multiple routetables

// Routes is an abstract, pluggable interface for advanced routing rules.
type Routes interface {
	// RouteTables get all available route tables.
	RouteTables(clusterName string) ([]string, error)
	// ListRoutes lists all managed routes that belong to the specified clusterName
	ListRoutes(clusterName string, table string) ([]*cloudprovider.Route, error)
	// CreateRoute creates the described managed route
	// route.Name will be ignored, although the cloud-provider may use nameHint
	// to create a more user-meaningful name.
	CreateRoute(clusterName string, nameHint string, table string, route *cloudprovider.Route) error
	// DeleteRoute deletes the specified managed route
	// Route should be as returned by ListRoutes
	DeleteRoute(clusterName string, table string, route *cloudprovider.Route) error
}

from cloud-provider.

fejta-bot avatar fejta-bot commented on June 30, 2024

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

from cloud-provider.

fejta-bot avatar fejta-bot commented on June 30, 2024

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

from cloud-provider.

k8s-ci-robot avatar k8s-ci-robot commented on June 30, 2024

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from cloud-provider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.