Support of instance metadata service about cloud-provider HOT 17 CLOSED

Opened the KEP here: kubernetes/enhancements#1158.

from cloud-provider.

ref: #15 #14 #18

from cloud-provider.

I'm not sure if this will be feasible, but at the very least we should focus efforts in making controllers API quota sensitive before we invest efforts in something like this. We can make API quota sensitive controllers a high priority for v1.16 as a first step and go from there. What do you think?

from cloud-provider.

We can make API quota sensitive controllers a high priority for v1.16 as a first step and go from there. What do you think?

Yep, that may be the first step. Meanwhile, I'm thinking the solutions for such issues, so that CCM still has the same performance as KCM.

from cloud-provider.

so that CCM still has the same performance as KCM.

The only controller that is different from KCM is cloud node controller, I think kubernetes/kubernetes#75405 should help with this a lot

from cloud-provider.

I think kubernetes/kubernetes#75405 should help with this a lot

Yep, but still not enough. e.g. for cluster provision step, hundreds of nodes are initialized at the same time. kubernetes/kubernetes#75405 could reduce the errors in node controller, but the node initialization may be still slow because of API throttling.

With instance metadata, however, all nodes could init them without any API invoking, hence no API throttling would happen and nodes could be registered much faster.

from cloud-provider.

Yep, but still not enough. e.g. for cluster provision step, hundreds of nodes are initialized at the same time. kubernetes/kubernetes#75405 could reduce the errors in node controller, but the node initialization may be still slow because of API throttling.

Agreed that we should improve this, but we should be mindful that this is a one time cost when the cluster is being created and we should optimize for that and nothing more.

from cloud-provider.

@feiskyer are you able to validate if kubernetes/kubernetes#75405 is helping with this problem for Azure?

from cloud-provider.

@andrewsykim Yep, of course. Would do it.

from cloud-provider.

@feiskyer any updates on this one?

from cloud-provider.

@andrewsykim Based on Azure API throttles, this is still a hard requirement for Azure cloud provider. I'm planning to draft a proposal for this during v1.16.

/milestone v1.16
/assign

from cloud-provider.

@andrewsykim I'm preparing the proposal here. Would you like having a look before I send it out as KEP?

from cloud-provider.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from cloud-provider.

/remove-lifecycle stale

from cloud-provider.

/lifecycle frozen

from cloud-provider.

/close

from cloud-provider.

@andrewsykim: Closing this issue.

from cloud-provider.