Giter VIP home page Giter VIP logo

Comments (11)

bowei avatar bowei commented on September 26, 2024 1

@cmluciano -- thanks for taking a look at this.

The procedure from kube devel should work with modifications -- I will add a doc. Unfortunately, due to some issues with the way the kubernetes repo is setup, glide does not work at the moment.

from dns.

GheRivero avatar GheRivero commented on September 26, 2024 1

I'm not a fan of not using stable releases as dependencies, could be a nightmare to debug if they change something without noticing it

from dns.

cmluciano avatar cmluciano commented on September 26, 2024

I tried this locally, but DNS does not have the proscriptive procedure that kube devel has.

Upon checking out release 1.5 for client-go, I ran godep save which seemed to change a bunch of stuff in vendor that was unrelated to this package.

I also noticed that we are building with Go 1.6 and Kube master is using 1.7. Should we bump this too?

Please let me know if I'm heading in the right direction. I'm more familiar with dependency systems like glide.

from dns.

cmluciano avatar cmluciano commented on September 26, 2024

Thanks a ton! I will try again with your doc.

from dns.

bowei avatar bowei commented on September 26, 2024

@cmluciano -- I added some scripts to make it easier to use godep, please take a look:

https://github.com/kubernetes/dns/blob/master/docs/go-dependencies.md

from dns.

cmluciano avatar cmluciano commented on September 26, 2024

Awesome PR forthcoming

from dns.

cmluciano avatar cmluciano commented on September 26, 2024

Just conforming, would we like client-go v1.5 or the pre-release2?

from dns.

bowei avatar bowei commented on September 26, 2024

@cmluciano -- it should be client-go v.1.5

@GheRivero -- the vendored client must be updated explicitly (e.g. via a commit). Tracking an external version should be more stable than grabbing a commit off of HEAD.

from dns.

cmluciano avatar cmluciano commented on September 26, 2024

Yep, the v1.5 has things stored under a 1.5 directory, which threw me off a bit.

from dns.

cmluciano avatar cmluciano commented on September 26, 2024

Decision is to wait for the latest tagged release when all apimlchinery is figured out. Using the current tagged releases would result in reverted code.

from dns.

cmluciano avatar cmluciano commented on September 26, 2024

@bowei going to take another stab at this today since the 1.6 compatible version is in beta

from dns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.