client-go: Add metrics into informer about enhancements HOT 14 OPEN

Hi @chenk008 ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

from enhancements.

/sig api-machinery

from enhancements.

related issue:
kubernetes/client-go#1027
kubernetes-sigs/controller-runtime#817
kubernetes/kubernetes#121662
kubernetes/kubernetes#117123

from enhancements.

It's useful to find out whether there are unhandled events received by reflector.

from enhancements.

/assign @logicalhan

from enhancements.

/label lead-opted-in
/milestone v1.30

from enhancements.

Hello @logicalhan 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.30.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just want to update the following but it's not required for alpha stage and it will serve for future stages:

• Make sure that the filled README.md file is merged to the k/enhancements repo. Moreover, all questions in the PRR questionnaire need to be answered.
• Make sure that the KEP status is marked as implementable and the latest-milestone is 1.30, while the reviewers and approvers are there.
• Make sure that there is graduation criteria at least for alpha stage.
• Make sure that there is a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here)

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well, I couldn't find any related PR regarding this KEP in k/enhancements. Thank you!

from enhancements.

I have reverted kubernetes/kubernetes#74636 in my test cluster (1.28), and created 4 secrets/configmap/pods. Each pod use one secret and configmap.

for i in $(seq 1 4);
do 
kubectl apply -f - <<EOF
apiVersion: v1
kind: Pod
metadata:
  name: my-secret$i
spec:
  volumes:
  - name: secret-volume
    secret:
      secretName: my-secret$i
  - name: configmap-volume
    configMap:
      name: my-config$i
  containers:
    - name: dotfile-test-container
      image: nginx
      volumeMounts:
      - name: secret-volume
        readOnly: true
        mountPath: "/etc/secret-volume"
      - name: configmap-volume
        readOnly: true
        mountPath: "/etc/configmap-volume"
EOF

done

This is kubelet memory usage percentage graph. The memory does not continuously grow.

This is reflector metrics

from enhancements.

According to kubernetes/kubernetes#73587, the memory leak is caused by quantile.newStream, every quantile.Stream contains an array with 500 quantile.Sample.

@logicalhan We can reduce summary age/ageBuckets to mitigate memory leak in reflector.

from enhancements.

Hello @logicalhan 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024. (In few hours) And I found the open PR #4349.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.30.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just want to update the following but it's not required for alpha stage and it will serve for future stages:

• Make sure that the filled README.md file is merged to the k/enhancements repo. Moreover, all questions in the PRR questionnaire need to be answered.
• Make sure that the KEP status is marked as implementable and the latest-milestone is 1.30, while the reviewers and approvers are there.
• Make sure that there is graduation criteria at least for alpha stage.
• Make sure that there is a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here)

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well, I couldn't find any related PR regarding this KEP in k/enhancements. Thank you!

from enhancements.

Hello 👋, v1.30 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.30, please file an exception request. Thanks!

from enhancements.

/milestone clear

from enhancements.

Hello @chenk008 @logicalhan 👋, 1.30 Docs Lead here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

from enhancements.

Hey again @logicalhan and @chenk008 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

• kubernetes/kubernetes#123367

With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

from enhancements.