Comments (10)
@kseifriedredhat Totally agree -- can you point to stuff as you see it and we'll fix it up. Or send a PR.
Thanks!
from kubernetes.
Just grep the source, so for example:
./kubernetes-master/cluster/saltbase/salt/kube-proxy/default:DAEMON_ARGS="$DAEMON_ARGS
--etcd_servers=http://{{ ips[0][0] }}:4001"
./kubernetes-master/cluster/saltbase/salt/kubelet/default:DAEMON_ARGS="$DAEMON_ARGS
-etcd_servers=http://{{ ips[0][0] }}:4001 -address=$HOSTNAME"
./kubernetes-master/cluster/saltbase/salt/apiserver/default:DAEMON_ARGS="$DAEMON_ARGS
-etcd_servers=http://{{ ips[0][0] }}:4001"
./kubernetes-master/cluster/saltbase/salt/controller-manager/default:DAEMON_ARGS="$DAEMON_ARGS
-etcd_servers=http://{{ ips[0][0] }}:4001"
from kubernetes.
Those are all intra-cluster communication. In the typical deployment none of those would be going over a WAN link. While ideally that stuff would be over TLS also, distributing key material in a secure way becomes difficult in an automated way.
I'd prioritize places where we grab resources over the internet over securing intra-cluster communication.
from kubernetes.
I filed #129 to track intra-cluster communication.
from kubernetes.
Is this meant to now refer to communication from the client rather than from the node components? If not, then it and #129 are covering the same thing and this should be closed.
from kubernetes.
If you replace all these with TLS via #129 then yes, that would cover this. Does your documentation specifically state that the intra cluster nodes need to have a trusted network, becauce if not this should probably be given a CVE.
from kubernetes.
TODO: audit code for all usage of http instead of https and file separate issues for each non-benign one. E.g. apiserver to same machine etcd is fine via http.
from kubernetes.
This audit was done and reported in #129
from kubernetes.
I did a quick audit of the cluster/
directory to see where I could find places that we are fetching resources over the internet and found the following:
In build scripts (Makefiles / Dockerfiles):
- https://github.com/GoogleCloudPlatform/kubernetes/blob/master/cluster/images/hyperkube/Makefile#L6
- https://github.com/GoogleCloudPlatform/kubernetes/blob/master/cluster/addons/fluentd-elasticsearch/fluentd-es-image/Dockerfile#L24
- https://github.com/GoogleCloudPlatform/kubernetes/blob/master/cluster/addons/fluentd-elasticsearch/kibana-image/Dockerfile#L13
- https://github.com/GoogleCloudPlatform/kubernetes/blob/master/cluster/images/nginx/backports.list#L1
In cluster initialization scripts:
- https://github.com/GoogleCloudPlatform/kubernetes/blob/master/cluster/gce/configure-vm.sh#L295-L296
- https://github.com/GoogleCloudPlatform/kubernetes/blob/master/cluster/libvirt-coreos/util.sh#L120
- https://github.com/GoogleCloudPlatform/kubernetes/blob/master/cluster/rackspace/cloud-config/master-cloud-config.yaml#L121
from kubernetes.
The intra-cluster audit was covered in #129 and I've done an audit over cluster initialization scripts here and sent PRs to fix a couple of easy cases and filed separate bugs for the remaining occurrences. Marking this issue as fixed.
from kubernetes.
Related Issues (20)
- [Flaking Test] UT TestSchedulerGuaranteeNonNilNodeInSchedulingCycle HOT 1
- Server-side apply bumps resourceVersion when re-applying the same object HOT 3
- Unable to join worker node to master node HOT 4
- DRA: add e2e_node tests HOT 4
- What Is the Meaning of "Updating CRD OpenAPI spec because xxx changed" in the apiserver Log? HOT 3
- SVM RV Semantics: assert that kine RV semantics match etcd
- garbagecollector.GetDeletableResources logs json encoding error instead of actual error HOT 2
- service.spec.externalIPs is unnecessarily limited (enhancement request) HOT 3
- SVM RV Semantics: assert that k8s-dqlite RV semantics match etcd
- SVM RV Semantics: assert that kubebrain RV semantics match etcd HOT 1
- Cpu Resources Container limits test is flaky for Windows on containerd 1.7 HOT 5
- Improve the jitter value for kubelet's serviceAccountToken projected volume source HOT 1
- Readiness probe stops too early at eviction HOT 3
- Mano HOT 4
- Kubelet will only get machine info when it is started. HOT 3
- kubectl describe uses Endpoints instead of EndpointSlices HOT 5
- The Version Skew Policy does not mention aggregated apiservers HOT 5
- As of go 1.22, there's no need to use the unsafe package for string to bytes conversion HOT 6
- Provide an easy way to send graceful shutdown signal to all processes in a Windows container HOT 2
- Error upgrading to 1.29.x with external CA HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kubernetes.