Giter VIP home page Giter VIP logo

Comments (5)

dlorenc avatar dlorenc commented on May 17, 2024

cc @ethernetdan

from minikube.

luxas avatar luxas commented on May 17, 2024

+1 for this of course.
If it gets even more complex, there's reason to move scripts (bash) to build/ like k8s does.

from minikube.

ethernetdan avatar ethernetdan commented on May 17, 2024

Since minikube's primary usecase for localkube is providing a Kube cluster within a Linux environment, I definitely think we should optimize for that usecase.

The current build step in the PR compiles it statically using an external linker while stripping symbols:
go build --ldflags '-extldflags "-static" --s -w' k8s.io/minikube/cmd/localkube

The static compilation was intended to support running from a "scratch" Docker image, which is not a requirement in minikube. The external linker usage is to support static compilation with cAdvisor.

If we decide to support other platforms we should probably use conditional compilation to remove the components that require Linux features (ie. proxy, kubelet) when targeting platforms other than Linux. This would require having changing components to register themselves in init blocks.

from minikube.

luxas avatar luxas commented on May 17, 2024

localkube targets: linux/amd64, linux/arm, linux/arm64, linux/ppc64le. Dynamically built until we fix cAdvisor: google/cadvisor#1237 and kubelet in turn. I've already done the hard parts with dynamic cross-compilation (which is a bit tricky) with Kubernetes, so we'll just reuse that code.

minikube targets: linux/amd64, linux/arm, linux/arm64, linux/ppc64le, darwin/amd64, windows/amd64. Statically built. Should offer both a VM, dockerized and maybe host env for running localkube.

from minikube.

dlorenc avatar dlorenc commented on May 17, 2024

Resolved by #43

from minikube.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.