Improve support for homebrew about kubeshark HOT 8 CLOSED

Inform AND delete. In both cases.

from kubeshark.

1. Fix version issue
2. Fix install script
3. Send PR to brew/core with kubeshark to be available without explicit tap

from kubeshark.

1. Done

Regarding install script, I have questions

• If kubeshark installed with homebrew and now we run install script, should it:

1. only inform user about kubeshark existing installation
2. inform AND delete existing installation before proceeding (like do actual brew uninstalll)

• If kubeshark installed with install script and now we run brew install, should it:

1. only inform user about kubeshark existing installation
2. inform AND delete existing installation before proceeding (removing binary with rm)

@alongir

from kubeshark.

@alongir in installation script it is possible to do "brew uninstall kubeshark" -> PR here #1503

But it is not possible vice versa.
If brew runs rm for file created by installation script - it fails due to that file created with sudo.
And sudo is not allowed to be used in brew formulae.

Should we proceed then only with removing kubeshark for case when we install with script?
Because I'd rather keep it informative in both cases, then removing in one and failing in another

from kubeshark.

2. done

3. in progress

• PR on review Homebrew/homebrew-core#164578
• We need to automate version updates after PR is merged https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request#create-your-pull-request-from-a-new-branch

from kubeshark.

You probably want these for automated bumps instead of reinventing the wheel:
https://github.com/marketplace/actions/bump-homebrew-formula or https://github.com/marketplace/actions/homebrew-bump-formula

from kubeshark.

@SMillerDev there was no plan to invent the wheel) It was just a note to not forget about it. Thank you for the links!

from kubeshark.

Ok, that took some time, but it is done now

from kubeshark.