Build failure with matrices 0.5.0 about cubicbezier HOT 8 CLOSED

I'll look at it this evening

from cubicbezier.

Can you upload this to hackage or add another maintainer to hackage?

from cubicbezier.

As far as I can tell this fix is as easy as changing to matrices 0.4.1. IMHO, this issue is quite important as the popular "diagrams" library relies on this.

from cubicbezier.

@kuribas you already merged a fix for this issue (#10). All that is needed is to upload to Hackage.

from cubicbezier.

Unless I'm missing something (and I very well could be), this doesn't fix the problem and in fact is the very commit which introduces it. The docs for version 0.4.1 (the version before that commit) is here, and as you can see it exports the unsafeTakeRow function, whereas version 0.5.0 only exports the safe counterpart takeRow.

from cubicbezier.

In fact this code isn't used, so I could remove the dependency.

from cubicbezier.

closing it since the package builds with matrices 0.5.0

from cubicbezier.

@zac-garby No, that commit changed the import from Data.Matrix.Generic to Data.Matrix.Class, which does export unsafeTakeRow. That commit certainly did not introduce the problem, the problem was just that the old code didn't work with version 0.5.0 of matrices due to the changes in exports. After that commit, cubicbezier now only works with version 0.5.0 of matrices (which seems fine).

@kuribas Thanks for uploading!

from cubicbezier.