Giter VIP home page Giter VIP logo

Comments (2)

Wenzel avatar Wenzel commented on August 22, 2024

The reason why i was catched all these different exceptions here was just to have some statistic at the beginning.

I wanted to know if a hook failed because of a KeyError exception (so the hook implementation was faulty), or if libvmi failed to read the memory, or even if the memory access was not consistent (dump test on ObjectAttributes fields).

This self.stats was just to give me some visibility after running Nitro.

My idea here would be to replace that code by a generic exception handler, to catch everything.

try:
    hook(syscall, self)
except Exception as e:
    logging.exception(e)

It's critically important to catch any exception that could be raised while a hook is being processed.
Otherwise we are not ackowledging the kernel and the VM is frozen and has to be killed

from nitro.

Wenzel avatar Wenzel commented on August 22, 2024

Actually we are already catching everything.

I suggest we should remove these specific exception handlers, and just log the exception on the logging output.

from nitro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.