Giter VIP home page Giter VIP logo

Comments (16)

faho avatar faho commented on June 14, 2024

Great that you like the script.

So, what do you mean by "don't work" - they simply don't do anything? Do you have them bound to anything? Do moving right or down work?

If you are using KWin 5 (with Plasma 5), then this is known - shortcuts don't work for that version yet and I've reported it.

from kwin-tiling.

thezimmee avatar thezimmee commented on June 14, 2024

Correct, they simply don't do anything. And yes, I have them bound (Move Window Left is Meta+Ctrl+J, Move Window Down Up is Meta+Ctrl+K). When I check my KWin version it says I am running 4.11.12, KDE Development Platform 4.14.1.

It's strange because all the other shortcuts and features work great; it's just those two shortcuts. Any ideas?

from kwin-tiling.

faho avatar faho commented on June 14, 2024

Hmm... just looking at the code I can't come up with anything. That means I'll have to switch back to KWin 4 to test this.

from kwin-tiling.

flying-sheep avatar flying-sheep commented on June 14, 2024

there are multiple shortcuts that could do what we want.

  • Move Window {Up,Down,Left,Right}
  • Window Quick Tile {Up,Down,Left,Right}
  • Window Pack {Up,Down,Left,Right}

i think the quick tile ones are most practical if it is at all possible to hook into KWin behavior here.

btw my shortcuts (⌘ = meta, ⇧ = shift):

  • ⌘ ↑/↓ = move to the prev/next workspace (workspaces are aligned vertically)
  • ⌘ ←/→ = switch window focus prev/next
  • ⌘ ⇧ ↓/↑ = move window to the prev/next workspace
  • ⌘ ⇧ ←/→ = move window to the prev/next screen (screens are aligned horizontally)

i would like to add combinations with the alt key for shifting windows on one screen.

from kwin-tiling.

faho avatar faho commented on June 14, 2024

@Ithez:
Okay, if you can, try daa807b.

I still haven't gotten around to trying kwin4 again, but I've seen something in the code which the commit message should explain.

@flying-sheep: I don't think you quite got what this bug's about.

i would like to add combinations with the alt key for shifting windows on one screen.

Kwin actually seems to have a shortcut for that. Note however that multimonitor support is currently basically broken - see #32. There are fixes in the "multimonitor" branch, but I don't want to merge them until I've either fixed everything, or I've added a proper way to disable tiling per-monitor.

Window Quick Tile {Up,Down,Left,Right}

Just checked, doesn't seem like it emits a geometryChanged signal.

from kwin-tiling.

flying-sheep avatar flying-sheep commented on June 14, 2024

i didn’t? i thought this was about moving windows on one screen, one workspace. e.g. when moving the left of two tiled windows to the right, it would switch places with the window on the right.

no?

from kwin-tiling.

faho avatar faho commented on June 14, 2024

It is, but that doesn't have anything to do with kwin's built-in shortcuts - they could be used, but the script already has tiling-aware shortcuts for this.

from kwin-tiling.

flying-sheep avatar flying-sheep commented on June 14, 2024

why not use the kwin ones if they would do something equivalent to what we want to do?

from kwin-tiling.

faho avatar faho commented on June 14, 2024

That's a possibility (I have removed shortcuts for selecting windows to the {left,right,top,bottom} because they were redundant), but would need to actually work (obviously). From my (limited) tests, they don't seem to send a resize or geometrychanged signal - what they do appears to be impossible to determine from the script.

from kwin-tiling.

flying-sheep avatar flying-sheep commented on June 14, 2024

It would be a great enhancement to kwin if you could hook into actions
triggered by shortcuts, intercept and possibly redefine them.

Similarly to normal JS event handling, event.preventDefault() or
returning false would stop the normal thing from happening

faho [email protected] schrieb am Fr., 19. Dez. 2014 14:19:

That's a possibility (I have removed shortcuts for selecting windows to
the {left,right,top,bottom} because they were redundant), but would need to
actually work (obviously). From my (limited) tests, they don't seem to send
a resize or geometrychanged signal - what they do appears to be impossible
to determine from the script.


Reply to this email directly or view it on GitHub
#33 (comment).

from kwin-tiling.

faho avatar faho commented on June 14, 2024

So since I always wanted to give Fedora a spin I have now set up a VM running KDE SC4, in which I have just committed 1c976f0 (as a fixup to the commit before it), which takes gaps into account when getting a tile by position.

If that was your issue, it is now fixed.

If not, please reopen this or open another one.

from kwin-tiling.

fbob avatar fbob commented on June 14, 2024

My keyboard shortcuts for "Move Window ..." don't work. I bind them to meta+maj+arrow keys ...

I'm using kde 4.13.3 on kubuntu 14.04 with current git version of the kwin-tiling script.

I would really appreciate any help to get these shortcuts working.
Thank you very much !

from kwin-tiling.

faho avatar faho commented on June 14, 2024

Does it fail regardless of what key you bind it to? Does the script work otherwise?

from kwin-tiling.

fbob avatar fbob commented on June 14, 2024

It looks like so, I've just changed the key bindings (try the default + other ones) and got the same effect: nothing move.
By the way the others kwin-tiling script features are working wonderfully :) Thanks !

from kwin-tiling.

faho avatar faho commented on June 14, 2024

Hmmm... I'm going to need some debug information. The first thing you could do is to upload your ~/.xsession-errors (and you can scrub anything personal or obviously not KWin related, but please don't be too eager). If that doesn't yield any errors, then we'd have to add some debug prints (yeah, I know).

In ~/.kde4/share/apps/kwin/scripts/kwin-script-tiling/contents/code/tilingmanager.js (open with a text editor) in _moveTile (line 699 on my copy, though I'm not sure I've commited all P4 stuff), right before if (direction == Direction.Left) { (line 708), could you add the following:

print("TilingManager._moveTile", client);
print(client.resourceClass.toString(), direction);

then start kwin --replace in a terminal, try to move a tile and upload the output?

from kwin-tiling.

fbob avatar fbob commented on June 14, 2024

Here is the ~/.xsession-errors:

 Script for ibus started at run_im.
 Script for auto started at run_im.
 Script for default started at run_im.

After the modification of tilingmanager.js a kwin --replace gives me:

% kwin --replace
QDBusConnection: session D-Bus connection created before QCoreApplication. Application may  misbehave.
QCoreApplication::sendPostedEvents: Cannot send posted events for objects in another thread
QCoreApplication::sendPostedEvents: Cannot send posted events for objects in another thread
QCoreApplication::sendPostedEvents: Cannot send posted events for objects in another thread
QCoreApplication::sendPostedEvents: Cannot send posted events for objects in another thread
Signal test 1: SUCCESS
Signal test 2: SUCCESS
Testing configuration
Reading floaters
Read floaters
Configuration option floaters :  latexdraw,yakuake,plasma,plasma-desktop,krunner,plugin-container,klipper,Wine
Starting tiling
Creating HalfLayout
Creating HalfLayout

And when I try to move a window to the left with my keyboard shortcut, I get:

TilingManager._moveTile KWin::Client(name = "")
systemsettings 2

Hope this help :)

from kwin-tiling.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.