conda-forge package about pydelatin HOT 8 CLOSED

Sure

from pydelatin.

😄 Thanks for taking a stab at conda-forge here again, and apologies for my trouble in correctly packaging! Packaging is hard!

I'm still learning best practices for wrapping lower-level code (especially since I don't know C/C++ that well). In this package I actually expose two libraries, the Pybind11 source is built from src/ and is exposed as _pydelatin; then I have a separate wrapper in pydelatin/ that's exposed as pydelatin. This helped since I couldn't really figure out how to pass 2D numpy arrays back from C++ directly.

Looking at the 0.2.0 source tarball, it looks like the src/ folder exists. So it seems like it should work for building from source locally?

Separately, this does rely on one other external library: glm. It should be easy to work with, since it's a header-only library. That said, I spent a couple hours last night trying to get windows wheels to work, and just couldn't figure out how to correctly modify the include paths 😂 . So maybe you'd need to put glm on conda? I don't know

from pydelatin.

So glm is on conda-forge: https://github.com/conda-forge/glm-feedstock
Maybe I was just missing that one. But anyway in conda-forge we shouldn't vendor another package, so I'm doing one for hmm.
Thanks for the information, I'll let you know how it goes!

from pydelatin.

Ok, it seems like I'd need to make changes to pydelatin to support an external hmm?

Like I'd probably need to change these includes

to

#include <hmm/base.h>
#include <hmm/heightmap.h>
#include <hmm/triangulator.h>

The main.cpp is the only C++ file I modified directly. Since I'm a total noob to good building practices, I might be wary of making changes unless it's clear how to also change the wheel building process. Like I know I should be able to fetch hmm and glm from github, and link against them in main.cpp without hardcoding anything, but I need to research how to do that

from pydelatin.

OK I'm done with hmm: conda-forge/staged-recipes#12915
Would you like to be a maintainer of the conda-forge package?

from pydelatin.

You know more than me about pip packaging, but what are the options to not vendor another library (here hmm and glm)? Can you download e.g. https://github.com/fogleman/hmm/archive/v1.1.0.tar.gz?
In any case, yes you will need to change to:

#include "hmm/base.h"
#include "hmm/heightmap.h"
#include "hmm/triangulator.h"

from pydelatin.

Maybe it's fine for now, we can see if we can improve that in the future.

from pydelatin.

We now have a conda-forge package: https://github.com/conda-forge/pydelatin-feedstock
To install it:

$ conda install pydelatin -c conda-forge

Thanks again for this great library!

from pydelatin.