using scan_files without file_cb about clamscan HOT 6 CLOSED

Thanks for the bug report Nicolas! I see you've put in a PR. I'll review it and merge it in if I can.

from clamscan.

I apologize for the state that section of the code is in. It looks like the first bug was caused by the dreaded "this" vs "self" annoyance. Your PR addresses that, so that's good. But, you're right... the rest of the code in that block just doesn't make any sense the way I had it. Looks like I copied it from scan_dir and never got around to making it right for scan_files. It's rather embarrassing, actually.

Once I get your code merged in, I think it's time I wrote some tests for the module.

from clamscan.

Yes Kyle, but no problem about it.

I would help you writing some tests if you want.

from clamscan.

Thanks Nicolas. I'm writing some tests right now. I'll push them out to github once they're done and you can add any that you'd like to make it more comprehensive--up to you. I'll be using chai and mocha. After I have the tests up, I will publish the updated module to NPM and close this Issue.

from clamscan.

Thanks for the pull request Nicolas! I've merged it in, written tests, and published a new version (0.7.0) to NPM. See the History file for details.

from clamscan.

Just realized the modifications I made to the script now REQUIRE Node > 0.12. I'm in the process of fixing that now. The version and package file has been bumped to 0.7.1 to reflect the requirement of 0.12.

Sorry about that!

from clamscan.