Comments (6)
Thanks for the useful suggestion!
I'm not sure what you mean about breaking the existing API. What would work perfectly well, I think, is the ability to supply more than one -F
option, e.g. cabextract -F *.mov -F *.avi foo.cab
The existing command line, since introducing filtering, has only allowed one -F
option, so all current usages are to either supply zero or one -F
option. Allowing more would be backwards compatible.
What do you think?
from libmspack.
That sounds perfect! Chalk up the "breaking API" comment to my limited understanding of opt. If you look at my fork, you will see that the additional filters are being parsed as the "extra" args. Which is what cabextract normally sees as additional cab files. So my fork emits a warning that only the first file is seen as a cab file and all others are seen as filters. Your way is better and doesn't break that usage.
from libmspack.
I added the feature in commits c45f055 and cdcaeb9 - please let me know if it works for you.
from libmspack.
Thank you for your patience on testing. Works perfectly.
One note: when I tried to compile with the 1.9.1 makefile, gcc threw an error with the new code. If you've already adjusted the makefile for the next release, then ignore this.
Exact error (when running make):
gcc -DHAVE_CONFIG_H -I. -I./mspack -DMSPACK_NO_DEFAULT_SYSTEM -g -O2 -c -o src/cabextract.o src/cabextract.c
src/cabextract.c: In function ‘process_cabinet’:
src/cabextract.c:470:9: error: ‘for’ loop initial declarations are only allowed in C99 mode
for (struct filter *f = args.filters; f; f = f->next) {
from libmspack.
Thanks for testing. I fixed the issue you encountered in 56fe06f52403e7d19160767c6af060b2b528a2ff - I'd quite like to use C99 standards, but first I need to update the build scripts so they check for and turn on C99 mode. So I've shelved that for now, gone back to C89, and I'll look at C99 in the future.
from libmspack.
This has been released in cabextract 1.10
from libmspack.
Related Issues (20)
- cabextract doesn't build from master HOT 2
- memory exhausted in oabd_decompress() HOT 2
- memory exhausted in chmd_read_headers() HOT 1
- Heap buffer overflow in chmd_read_headers() HOT 7
- 1.9.1: issue with dist tar ball HOT 2
- Not clear on Github how to get libmspack vs cabextract releases HOT 17
- chmextract HOT 2
- Conflicting definitions for copy_fh HOT 3
- configure / libtool fails with -flto HOT 12
- configure / libtool fails with -flto HOT 6
- Compilier warnings with 1.9.1 HOT 4
- Compiler error with 1.9.1 / gcc 9.3.1 HOT 5
- Malloc size error in chmd.c:1327:34 HOT 2
- extra = 0 confusion HOT 4
- build fails on macos HOT 1
- cabextract: Writing into symlinks HOT 11
- Issue with KWAJ method 2 decompression HOT 2
- Fail to properly create path components coming from the archive HOT 3
- Cannot extract files from a .cab file containing file names encoded in shift_JIS HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libmspack.