Giter VIP home page Giter VIP logo

Comments (2)

L-u-k-e avatar L-u-k-e commented on September 16, 2024

The issue in these cases appears to be that the correct frame is never identified, becausemessage.href is undefined

messaage.href is set according to information passed from the browser itself to an event listener. (queryURL). I need to figure out if message.href is never being set, because queryURL for some reason isn't being called or if it is being explicitly set to undefined perhaps because the message was sent too early (DOM hasn't fully loaded).

The former seems more likely at this point...

from format.

L-u-k-e avatar L-u-k-e commented on September 16, 2024

There appears to be two causes to this issue. The first is that the tab change listener wasn't creating an href key in the object it passed to queryURL. This is what was causing hrefTop to be undefined sometimes. The fix has been implemented and will be committed today.

However there is a second cause to the problem. Sometimes, (especially prevalent in youtube) the url can change, but a new page is not actually loaded. Because hrefTop gets set when the top frame is loaded, the value of hrefTop becomes outdated, so the correct frame never gets found. You can switch tabs to fix this (now that tab switching works) I am opening a separate issue for this.

from format.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.