Giter VIP home page Giter VIP logo

Comments (7)

GoogleCodeExporter avatar GoogleCodeExporter commented on June 29, 2024
Which classe(s) of javamelody sould implement Ordered ? 
MonitoringSpringInterceptor, MonitoringSpringAdvisor, 
MonitoredWithInterfacePointcut, MonitoredWithAnnotationPointcut or 
SpringDataSourceBeanPostProcessor ?

What would be a suitable value to be returned by the implementation of 
getOrder() ? 0 ?

Thanks

Original comment by [email protected] on 1 Jul 2010 at 7:48

from javamelody.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 29, 2024
Hi,
Note that I would want to make a release tomorrow 3rd of june.

I think that MonitoringSpringAdvisor should implement Ordered (and it already 
does with its super-class by the way). Is that what you need? And I have 
commited 0 for getOrder(). Is it ok?
Thanks

Original comment by [email protected] on 2 Jul 2010 at 7:48

from javamelody.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 29, 2024
I thought it was MonitoringSpringInterceptor that needed it - for example se 
docs in 
http://www.jarvana.com/jarvana/view/org/springframework/spring/1.2.9/spring-1.2.
9-javadoc.jar!/org/springframework/aop/framework/ProxyFactoryBean.html.

The most important is that is configurable (settable) so that it can be 
configured by the end user. I think HIGHEST would be a sensible default. (A 
constant in the Ordered interface).

Original comment by [email protected] on 3 Jul 2010 at 12:40

from javamelody.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 29, 2024
Hi,
It seems that all Advisors implements Ordered (and "order" is settable on 
Advisors).
Have you tried the newly released version 1.17.0 (where the order of the 
advisor is 0 by default) ?

Original comment by [email protected] on 8 Jul 2010 at 9:15

from javamelody.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 29, 2024
Hi, Have you tried the newly released version 1.17.0 (where the order of the 
advisor is 0 by default and is settable) ?

Original comment by [email protected] on 16 Aug 2010 at 2:58

  • Changed title: Add support for Ordered interface (spring configuration)

from javamelody.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 29, 2024
Yes - but actually I just use aop:advisor directly in spring as I've extended 
the interceptor to do some additional stuff (logging times to a couple of slf4j 
loggers in a internal format).

Thanks!

Original comment by [email protected] on 16 Aug 2010 at 11:45

from javamelody.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 29, 2024
So I suppose the issue is fixed. (If not, it can be reopened.)
Thanks

Original comment by [email protected] on 17 Aug 2010 at 6:14

  • Changed state: Fixed

from javamelody.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.