Could ServerRequestFactory::marshallUriFromSapi() be made public? about laminas-diactoros HOT 4 CLOSED

Well aware, it's just that the public API becomes much bigger there.

If somebody can send me a patch to try and extract marshalUriFromSapi() into a well documented public API on a new class that we test independently (and can deprecate separately, if needed in future), that would probably be the best way forward :)

from laminas-diactoros.

Depends on the use-case: it would need to be extracted from ServerRequestFactory, IMO.

Wouldn't using this work?

Can you build a request and then get the URI from there?

from laminas-diactoros.

Can you build a request and then get the URI from there?

We build our own ServerRequest instance (using the various global functions Diactoros provides), so building Diactoros' ServerRequest instance just to get the Uri instance would be quite wasteful. All the parsing of PHP's global environment/request variables is non trivial amount of code, so would like to avoid doing it twice.

from laminas-diactoros.

Handled in #123

from laminas-diactoros.