Giter VIP home page Giter VIP logo

Comments (3)

akohlmey avatar akohlmey commented on May 19, 2024

There is one final and rather obscure issue that i observed running the test input. When using the attached input with 4 MPI tasks or more, the results are suddenly wrong. I've tracked this down to having to deal correctly with the case of having an empty neighbor list, which is much more likely for hybrid styles than for regular calculations. The problem seems to be caused by this line:
https://github.com/lammps/lammps/blob/lammps-icms/lib/gpu/lal_balance.h#L162
Where the number of "local" atoms is forced to be > 0. Unfortunately, changing it, so it will return zero, where there are no atoms in the list will result in kernel launch failures. On the other hand, when it is set to 1, it will copy data from the GPU to the host, that is bogus.

from lammps.

ndtrung81 avatar ndtrung81 commented on May 19, 2024

Thanks for the hints, Axel. Indeed it involves an empty neighbor list of local atoms. For this case, the checks to return are currently not correct, which then allows the program to continue to the part where the balancer is invoked. I have fixed the checks and created a pull request for this issue. I tested the input script with 4, 6 and 8 MPI tasks and it seems to work correctly now. Please double check this on your side. Thanks!

from lammps.

akohlmey avatar akohlmey commented on May 19, 2024

Exellent! It seems to work for me, too.

from lammps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.