Comments (5)
NOTE: This looks like an issue with the API itself, not the SDK. Can replicate the behavior using straight API calls.
Seems that the ability to add/remove aliases from the API is not working.
I can send the following payload:
{
"aliases" : []
}
which results in a 200 response, but the old aliases are still present:
{
"site": {
"id": 1402987,
"server_id": 329730,
"name": "test1.com",
"aliases": [
"test2.com",
"test3.com"
],
[...]
}
}
from forge-sdk.
I went back and re-read the documentation, and my original understanding of it was incorrect.
Currently, the API only supports ADDING aliases, not DELETING. Per the documentation:
Use this endpoint to add additional site aliases...
Submitting an empty array of aliases will have no effect, as you're just telling forge "Add nothing to the aliases."
As it stands, this is working as intended. Perhaps we can use this Issue to add the implementation to delete aliases?
from forge-sdk.
Feel free to send in a pr, thanks.
from forge-sdk.
Feel free to send in a pr, thanks.
We can't send in a PR for a function of the API. It's the API that's not removing the aliases, not just the SDK.
from forge-sdk.
You can delete aliases using Update Site: $forge->updateSite($serverId, $siteId, array $data);
See https://forge.laravel.com/api-documentation#update-site
hth
from forge-sdk.
Related Issues (20)
- Update FPM Pool configuration HOT 1
- Http Client error in forge, not in local HOT 1
- CreateSite api isolation=true goes on 502 error HOT 10
- Specify collation on database creation HOT 2
- Expose API endpoints for managing PHP versions HOT 3
- retry method in MakesHttpRequests is sending boolean values to TimeoutException HOT 1
- Call to a member function request() on null HOT 1
- Undefined array key "provision_command" HOT 2
- Managing Create Database User HOT 1
- Deployment output call returns the same log for every deployment on a server/site HOT 1
- Server ubuntuVersion property does not return a version below 20.04 HOT 1
- Some functions use a hard coded timeout of 30 HOT 2
- Deprecated Properties in PHP 8.2 HOT 7
- Add $phpVersion property to Laravel\Forge\Resources\Site HOT 2
- Update site tags via SDK/API HOT 1
- Routing in Forge Docs HOT 1
- Forge link broken in docs HOT 2
- Support `auto_source` in Site::updateDeploymentScript() HOT 1
- Add auto-source support for `updateSiteDeploymentScript` Method HOT 1
- Improve Exception handling for 422 / existing items HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from forge-sdk.