Comments (15)
OK
the 4 elements have been now fixed. Do you see anything else?
Should we release a first version of CRAN to facilitate integration?
from broom.helpers.
- I like your proposal! We explain that broom.helpers is the engine behind
tbl_regression()
and the GGally function. Illustrate the broom.helpers fns and show the output from the function that show pretty output. Maybe we just keep it as is for now, and when we've updated the backend of the packages, we can update? If that is ok with you, we can open another issue so we don't forget to make the update later.
issue created, cf. #28
- OK, sounds good
I will look at it this week-end
- I am just pointing this out. Either option does make sense. I'll leave it up to you!
OK, for now I will keep like that (more information). It will still be possible to change things later.
But I will update documentation to be clearer
- I'll add a small section to the current vignette now.
Thanks a lot.
I have the feeling that we should be able to release a first version next week.
from broom.helpers.
fixed by #22
from broom.helpers.
Are there any other vignettes to add before release? If not, I can remove the drop down list for Articles to a single link to the Getting Started vignette
from broom.helpers.
No I do not thinks we need an other vignette. I just completed the current with some more advanced examples.
from broom.helpers.
With pleasure for removing the dropdown list (I never explored all options of pkgdown)
from broom.helpers.
Codecoverage is now 100%. We have examples and a vignette.
There may be still some bugs but difficult to identify them without using the package.
What else do you think we should do before a first release?
from broom.helpers.
Are there any other vignettes to add before release? If not, I can remove the drop down list for Articles to a single link to the Getting Started vignette
done by #27
from broom.helpers.
I don't think there is anything that needs to be done...wow!
There are a couple of things we could think on:
- I don't think printing the tidy tibble in the README is showing a user what the package can do in the best way. I am not sure what would be better, however! Perhaps we add the forest plot to show that it can be created easily?
- When the header row is added, most columns that are consistent across the variable are filled (e.g.
var_type
,var_class
,var_label
). Thecontrasts
column, however, is not filled. To be consistent, I think it would be a good idea to fill this as well. - The columns
reference_row
andheader_row
are logical vectors that areNA
for some rows. I think for a new user, it would be easier if these were filled for every row (noNA
s). - One piece of documentation I think would be helpful to include an example tidy tibble with every addition possible along with a detailed description of what each column is (type, function that will add the column, and perhaps an example of how can be used).
from broom.helpers.
- I don't think printing the tidy tibble in the README is showing a user what the package can do in the best way. I am not sure what would be better, however! Perhaps we add the forest plot to show that it can be created easily?
This is a good question and it depends on who is the targetted audience of broom.helpes
: basic users or developers?
I would say that the purpose of this package is mainly to advanced users and programmers.
For basic users:
- the best is to use
tbl_regression()
to print a nice table - for a forest plot, the easy way will be to use
ggcoef_model()
(https://github.com/larmarange/JLutils/blob/master/R/ggcoef_model.R). Note that this is a dev version inJLutils
. I intend to rewrite it usingbroom.helpers
before integrating it inGGally
We can still add a forest plot in README. At a later stage, it would be relevant to update the README to say that the package is used in gtsummary
(for nice tables) and in GGally
(for nice model plots).
- When the header row is added, most columns that are consistent across the variable are filled (e.g.
var_type
,var_class
,var_label
). Thecontrasts
column, however, is not filled. To be consistent, I think it would be a good idea to fill this as well.
TRUE. Will update this.
- The columns
reference_row
andheader_row
are logical vectors that areNA
for some rows. I think for a new user, it would be easier if these were filled for every row (noNA
s).
Once again, it depends on the audience.
When I was writing the package, the interest of using NA
was to indicate an additional piece of information:
TRUE
that variable has a reference/header row and this is the reference/header rowFALSE
that variable has a reference/header row and this is not the reference/header rowNA
that variable doesn't have a reference/header row
It is true that it is not explained properly in the documentation.
For future development, I do not know if it is relevant to keep that distinction.
Once again, I'm not sure that basic users will manipulate the output of tidy_*()
functions.
- One piece of documentation I think would be helpful to include an example tidy tibble with every addition possible along with a detailed description of what each column is (type, function that will add the column, and perhaps an example of how can be used).
Good idea. Through an additional technical vignette?
from broom.helpers.
Thanks for your great responses. These are just thoughts I wanted to put out there.
-
I like your proposal! We explain that broom.helpers is the engine behind
tbl_regression()
and the GGally function. Illustrate the broom.helpers fns and show the output from the function that show pretty output. Maybe we just keep it as is for now, and when we've updated the backend of the packages, we can update? If that is ok with you, we can open another issue so we don't forget to make the update later. -
OK, sounds good
-
I am just pointing this out. Either option does make sense. I'll leave it up to you!
-
I'll add a small section to the current vignette now.
from broom.helpers.
FYI, I am updating the vignette, and i am getting an error the last code chunk. The error is coming from the tidy_add_term_labels()
call.
model_4 <- glm(
response ~ stage + grade * trt,
gtsummary::trial,
family = binomial,
contrasts = list(
stage = contr.poly,
grade = contr.helmert,
trt = contr.poly
)
)
model_4 %>%
tidy_and_attach(exponentiate = TRUE) %>%
tidy_add_reference_rows() %>%
tidy_add_estimate_to_reference_rows(exponentiate = TRUE) %>%
tidy_add_term_labels() %>%
rmarkdown::paged_table()
Error in if (is.null(names(y)) || any(names(y) == "")) { :
missing value where TRUE/FALSE needed
from broom.helpers.
That error should have been fixed today. Did you rebuild the package to be sure to use the last version?
from broom.helpers.
I think it's ready for submission to CRAN! Congratulations!
from broom.helpers.
Thanks for your help
from broom.helpers.
Related Issues (20)
- Support for mmrm models HOT 8
- Support for MASS::contr.sdif() contrasts
- Support for zero-inflated models
- beta regression is not supported yet HOT 2
- Considering a `tidy_post_fun` argument to `tidy_plus_plus()` HOT 2
- Support with coxphf model HOT 9
- Bug fixes and improvements for mixed models HOT 1
- tbl_regression (package gtsummary) and ggcoef_model (package ggstats) not working on the output of a replicate svyglm model HOT 2
- fantastic support of multivariate quantile regression for any quantile HOT 1
- Support for survival::cch model? HOT 5
- Avg_comparisons and nlme::lme() models HOT 1
- order of variable levels with marginal tidiers HOT 8
- Release broom.helpers 1.15.0
- Take into account (id) when computing model_get_n() for coxph models
- `marginaleffects::datagridcf()` is deprecated
- Do you know the status of the {margins} pkg? HOT 3
- Explore better support of VGAM::vglm() models HOT 1
- Execution time HOT 4
- marginaleffects::datagridcf() is deprecated
- pkgdown site has no search facility HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from broom.helpers.