Giter VIP home page Giter VIP logo

Comments (3)

lgeiger avatar lgeiger commented on July 24, 2024 1

@AdamHillier do you think we should change zookeeper.Field to have the same semantics as @property if initialized with a lambda function or used as a decorator, so that we get a new instance on every access to prevent issues like this? I came accross a similar issue last week as well when trying to use quantizers with learnable parameters.

Another solution would be to change quantizers here to normal @property instead of having them as fields, so that they are not cached on the class instance.

@itayalfia We'll take a closer look at this next week, since this is something we've come accross before and we should fix in a proper way. For now you can use #149, which should provide an intermediate fix for the issue.

from zoo.

lgeiger avatar lgeiger commented on July 24, 2024

Thanks for the detailed issue.

My suspicion is that one quantizer is created and reused for the entire model, and flip_ratio looks at the same quantizer with inputs of different shapes and fails because of this.

I noticed that in a different case too a few days ago. I think it is because we set the input quantizers like this so they are stored on the class which will fail since the metric has internal variables:

input_quantizer = Field(lambda: lq.quantizers.SteSign(clip_value=1.25))
kernel_quantizer = Field(lambda: lq.quantizers.SteSign(clip_value=1.25))

from zoo.

AdamHillier avatar AdamHillier commented on July 24, 2024

@AdamHillier do you think we should change zookeeper.Field to have the same semantics as @property if initialized with a lambda function or used as a decorator, so that we get a new instance on every access to prevent issues like this? I came accross a similar issue last week as well when trying to use quantizers with learnable parameters.

I've made a Zookeeper issue for this here: larq/zookeeper#134.

from zoo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.