Comments (6)
Good stuff, I'll bash it out over the next few days anyway, make some new tests etc. 😄
from runnable-exports.
And released 🎉 I've added you as contributor within the package.json. Thanks again, great work 👍
from runnable-exports.
Doesn't look too bad, I've got a very basic thing working right not.
Just wondering though are your tests currently working because after I did yarn install
the tests that throw errors were failing. I fixed them by changing the error.message.search
to error.stderr.search
but I want to check that it's broken for you too.
Also I noticed that if you pass in multiple args to an export from the command line that it becomes an array. If we just add in the spread operator (...
) we can separate the args again when we pass them to the exported function, just like make-runnable does. i.e.
const exportedFunc (args) => {
let var1 = args[0];
let var2 = args[1];
// etc.
}
becomes:
const exportedFunc = (var1, var2) => {
// function body
}
Personally I prefer this method, what do you think?
from runnable-exports.
I don't know actually about the error in test, I need to check. Anyway with a PR the tests will run on Travis, so we can double check on different versions of Node.
The change make sense to me. The code was written time ago, so feel free to make some improvements if you want. 😄
from runnable-exports.
Hi @emurphy-9, thanks for reporting this one. I think can be a nice improvement.
Do you want to try to raise a pull request for this? I'm a bit busy these days so I don't know when I will be able to make the change.
from runnable-exports.
@LasaleFamine Sure I can look into it, I haven't delved into your code but I can have a go. 😄
from runnable-exports.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from runnable-exports.