Comments (4)
That method was meant to be package-private - it is an implementation detail - and changing package-private methods is not considered a breaking change. However, it was for some reason declared with protected
scope instead. That was certainly a mistake; but in normal usage of the SDK no one would be subclassing User
, so application code would never be referencing this method. Could you clarify whether this was in fact a breaking change for your code?
To reiterate, this was a mistake on our part; our policy, as indicated in all of our changelogs, is to adhere to semver even in the case of a method that had been exposed unintentionally. But since we cannot unrelease the 4.9.0 release and, as mentioned, it is hard to imagine this actually affecting application code, I think the best course would be to simply acknowledge the error and move on.
from java-server-sdk.
Hi @marcosscriven,
@eli-darkly beat me to it in responding to your message. I wanted to add a couple items:
- I agree with Eli that the best course of action at this point is to acknowledge the error and move on. 4.9.0 was released over two months ago and as such, reverting the breaking change would in turn be a breaking change for anyone already using this version or a newer version.
- On the topic of generally attempting to follow semantic versioning guidelines -- you can read our SDK versioning policy to learn more about how we version our SDKs. This document helps define how we handle some of the ambiguities in the semantic versioning guidelines.
Cheers,
Ben
from java-server-sdk.
Hi @bwoskow-ld and @eli-darkly
Thanks for the prompt and helpful responses. This did indeed break a single line of our code, but only at compile time so not a big issue.
It did also happen to break a few tests as the API key in config is now null checked.
Both easily fixed - it just means busy work for an otherwise fully automated process.
from java-server-sdk.
I'm glad it was easy to work around. Our apologies for the slight inconvenience!
from java-server-sdk.
Related Issues (20)
- Launch Darkly Metrics conflating Version numbers. HOT 3
- Getting numerous Error posting diagnostic event (giving up permanently): HTTP error 401 (invalid SDK key) HOT 2
- Synk reports the low version of okHttp3 dependency HOT 3
- Vulnerability in snakeyaml HOT 3
- LaunchDarkly Client initialing failed even add LaunchDarkly Certificate to java key store. HOT 9
- Add shaded libraries as dependencies to `-thin` jar HOT 2
- `isInitialized` & `dataStore.isInitialized()` HOT 3
- Please provide ability to `LDClient` in non-blocking manner HOT 4
- fat jar brings in duplicate copy of `launchdarkly-logging` HOT 3
- Allow lazily computed defaultValues in LDClient to improve code readability HOT 6
- java-server-sdk is vulnerable to CVE-2022-1471 RCE HOT 3
- Builder object is not exist in V6 but is taken as an example in the docs HOT 6
- Evaluation can throw when the same segment is used in multiple rules within a single flag HOT 6
- StreamClosedByServerException: Stream closed by server HOT 13
- Vulnerability CVE-2022-1471 is introduced via SnakeYaml 1.32. Upgrading to 2.0 should fix it. HOT 3
- Have a robust in memory datastore fallback when the persistent data store connection is not working HOT 2
- update to guava 32.0.0 to resolve CVE-2023-2976 HOT 6
- ApiException.getMessage throws NullPointerException when IOException occurs HOT 1
- Stream continuously reset HOT 2
- Support for use of java-server-sdk library in GraalVM native image applications HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from java-server-sdk.