Giter VIP home page Giter VIP logo

Comments (10)

devoxin avatar devoxin commented on August 16, 2024 1

I'd just stick with my fork then tbh. There's speculation as to whether we leverage Java language features from versions after 8, or it could equally be due to a fault in how Gradle is being configured to compile the project, but extensive testing isn't worth it as I think the general consensus is that we don't want to retain support for super old Java versions so are ultimately looking at bumping the minimum version required to 11.

Just keep in mind with my fork, that it's missing a lot of the custom stuff like audio track isrcs and artwork URLs. If you don't need that then it should be no issue.

I'm going to go ahead and close this issue as I don't think there's much more to be said. If there is, you're free to join the Lavalink Discord server

from lavaplayer.

devoxin avatar devoxin commented on August 16, 2024

Try using a newer version of Java

from lavaplayer.

VadamDev avatar VadamDev commented on August 16, 2024

Hello.
It works on Java 17. But what if i wanna keep using Java 8 ? :x
This errors occurs when the build bytecode is in Java9+ since they changed the ByteBuffer class (see: https://www.morling.dev/blog/bytebuffer-and-the-dreaded-nosuchmethoderror/)

But the source compatiblity in the Lavaplayer build.gradle file is Java 8 (line 36) so i guess just adding targetCompatibility = JavaVersion.VERSION_1_8 would fix the issue

Otherwise, it would be cool to mention what minimum version of Java you need to use this fork ^^'

from lavaplayer.

devoxin avatar devoxin commented on August 16, 2024

But what if i wanna keep using Java 8 ? :x

Unless you have a specific requirement that forces you to use Java 8 I would really advise you upgrade. Aside from legacy software there's no real reason to continue using such an outdated version

from lavaplayer.

VadamDev avatar VadamDev commented on August 16, 2024

It's not a issue for this project, I can update but I have other legacy bots that I will need to update which will take time :x
Would be cool to have a fix honestly

from lavaplayer.

devoxin avatar devoxin commented on August 16, 2024

Could you give 08fe37d a try and see if it fixes your issue?

from lavaplayer.

VadamDev avatar VadamDev commented on August 16, 2024

Still get the same error (Same bot, JVM version etc...)

Gradle file juste in case:

dependencies {
    implementation 'com.github.lavalink-devs:lavaplayer:set-target-compatibility-SNAPSHOT'
}

tasks.withType(Tar).configureEach {
    duplicatesStrategy = DuplicatesStrategy.INCLUDE
}

tasks.withType(Zip).configureEach {
    duplicatesStrategy = DuplicatesStrategy.INCLUDE
}

from lavaplayer.

devoxin avatar devoxin commented on August 16, 2024

34f8ca0?

from lavaplayer.

VadamDev avatar VadamDev commented on August 16, 2024

Same issue

from lavaplayer.

VadamDev avatar VadamDev commented on August 16, 2024

Out of curiosity, I tried your fork (https://github.com/devoxin/lavaplayer) and it works with Java 8

from lavaplayer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.