Giter VIP home page Giter VIP logo

Comments (4)

lavary avatar lavary commented on July 16, 2024 3

@rossbearman illuminate/support was used for a couple of helper functions like array_get(), array_only, collect, and a few others. However, this dependency has been removed in the latest release of Crunz, which is 1.1.1.

The reference to Illuminate\Contracts\Mail\Mailer has been removed as well.

from crunz.

rossbearman avatar rossbearman commented on July 16, 2024

The only usage I can find in the code is the Mailer contract Illuminate\Contracts\Mail\Mailer in Event.php.

illuminate/support shouldn't be a dependency of a framework-agnostic package as it is a huge package itself, with a number of dependencies. It's intended to provide support packages for the Laravel framework itself and not really intended for use elsewhere, unless you're building a Laravel specific package that can be tied to a specific Laravel version.

from crunz.

boosis avatar boosis commented on July 16, 2024

Yes, I saw that. Even there it's only namespace, Mailer class is not used anywhere in that class

from crunz.

rossbearman avatar rossbearman commented on July 16, 2024

Good job, thanks for resolving this.

from crunz.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.