SoftDeletes not working. about laravel-nestedset HOT 8 CLOSED

What is working unexpected wihtout these modifications?

When I was writing this post, I realized how I can soft delete descendants, more precisely how to restore them if parent is restored.

from laravel-nestedset.

Please, update to 2.4.1, remove your modifications and test

from laravel-nestedset.

I update and test.
The problem is that the values of _lft and _rgt are not updated after restore. They contain values before delete.
Table has 2 categories with _lft and _rgt values: 1-2, 3-4. First node is soft deleted. After that table will contain: 1-2, 1-2. And after restore it must be: 1-2, 3-4 (order doesn't matter), but has: 1-2, 1-2.

from laravel-nestedset.

Lft and rgt shouldnt be changed when soft deleted at all
29 íÁÒ 2015 Ç. 20:27 ÐÏÌØÚÏ×ÁÔÅÌØ "asokol1981" [email protected]
ÎÁÐÉÓÁÌ:

I update and test.
The problem is that the values of _lft and _rgt are not updated after
restore. They contain values before delete.
Table has 2 categories with _lft and _rgt values: 1-2, 3-4. First node is
soft deleted. After that table will contain: 1-2, 1-2. And after restore it
must be: 1-2, 3-4 (order doesn't matter), but has: 1-2, 1-2.

Reply to this email directly or view it on GitHub
#43 (comment)
.

from laravel-nestedset.

Ok.

from laravel-nestedset.

Ok what? Is this what happens or not?
29 íÁÒ 2015 Ç. 20:47 ÐÏÌØÚÏ×ÁÔÅÌØ "asokol1981" [email protected]
ÎÁÐÉÓÁÌ:

Closed #43 #43.

Reply to this email directly or view it on GitHub
#43 (comment)
.

from laravel-nestedset.

SoftDeletes now should work. But I think not to change _lft and _rgt is not right. It will brake result of Node::getDescendantCount and may be will brake another expectations. :)

from laravel-nestedset.

Well, yeah, but you shouldnt strongly rely on this values. Anyways, i would
wipe soft deleted models from db from time to time.
29 íÁÒ 2015 Ç. 21:05 ÐÏÌØÚÏ×ÁÔÅÌØ "asokol1981" [email protected]
ÎÁÐÉÓÁÌ:

SoftDeletes now should work. But I think not to change _lft and _rgt is
not right. It will brake result of Node::getDescendantCount and may be
will brake another expectations. :)

Reply to this email directly or view it on GitHub
#43 (comment)
.

from laravel-nestedset.