Giter VIP home page Giter VIP logo

Comments (11)

lazyjinchuriki avatar lazyjinchuriki commented on June 16, 2024 1

I can assign this issue to you under Hactoberfest.
Can you work on that?

from pokedex.

Shubhamm33 avatar Shubhamm33 commented on June 16, 2024 1

Yes i've forked it, theres also some js issue in console..
i'll fix that too

from pokedex.

Shubhamm33 avatar Shubhamm33 commented on June 16, 2024 1

ohh okay got it now...
so first we need to fetch the pokemon type from pokemon, then their respective type data using this type endpoint...
i'll try this out then let you know

from pokedex.

lazyjinchuriki avatar lazyjinchuriki commented on June 16, 2024 1

You're the best!!

from pokedex.

AniketP04 avatar AniketP04 commented on June 16, 2024

I'm willing to work on this issue and collaborate with the maintainers. Please let me know how I can proceed.

from pokedex.

Kelvin-K avatar Kelvin-K commented on June 16, 2024

I saw the issue was still pending so I went ahead and created a pull request.
If you find this suitable, please assign this issue to me.

from pokedex.

Shubhamm33 avatar Shubhamm33 commented on June 16, 2024

Okay awesome...
i have pulled the updated
there are minor errors displaying in console..
fixed them as well...
please merge the updated, sending a PR
t19

from pokedex.

lazyjinchuriki avatar lazyjinchuriki commented on June 16, 2024

Thanks.

from pokedex.

Shubhamm33 avatar Shubhamm33 commented on June 16, 2024

There are 2 errors which i'm getting,
one for the images, which i'm ignoring since its loading on your end...

Other one is the /v2/type error...
for some pokemon /v2/type is not present in their response structure...
there are only 20 pokemon links available on the types endpoint

t20
t21
After 18 it has nothing, which gives error

i have also checked their documentation, it returns undefined for pokemon after 18, since its not present in the response body itself
t22
t23

Do you know why is that ?
I'm not able to understand, they dont have any issue in their docs as well..

from pokedex.

lazyjinchuriki avatar lazyjinchuriki commented on June 16, 2024

You see the type endpoint does not refer to each pokemon, instead it refers to each types (i.e. fire, water etc.)
There are only 20-21 types i think thus it will return undefined for more than that.
This issue is because someone created a PR for showing Strong Against and Weak Against types and I unknowingly merged it.

from pokedex.

Shubhamm33 avatar Shubhamm33 commented on June 16, 2024

Thankyou so much
i'll probably work on this in evening, currently in office!

from pokedex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.