Comments (11)
I can assign this issue to you under Hactoberfest.
Can you work on that?
from pokedex.
Yes i've forked it, theres also some js issue in console..
i'll fix that too
from pokedex.
ohh okay got it now...
so first we need to fetch the pokemon type from pokemon, then their respective type data using this type endpoint...
i'll try this out then let you know
from pokedex.
You're the best!!
from pokedex.
I'm willing to work on this issue and collaborate with the maintainers. Please let me know how I can proceed.
from pokedex.
I saw the issue was still pending so I went ahead and created a pull request.
If you find this suitable, please assign this issue to me.
from pokedex.
Okay awesome...
i have pulled the updated
there are minor errors displaying in console..
fixed them as well...
please merge the updated, sending a PR
from pokedex.
Thanks.
from pokedex.
There are 2 errors which i'm getting,
one for the images, which i'm ignoring since its loading on your end...
Other one is the /v2/type error...
for some pokemon /v2/type is not present in their response structure...
there are only 20 pokemon links available on the types endpoint
After 18 it has nothing, which gives error
i have also checked their documentation, it returns undefined for pokemon after 18, since its not present in the response body itself
Do you know why is that ?
I'm not able to understand, they dont have any issue in their docs as well..
from pokedex.
You see the type endpoint does not refer to each pokemon, instead it refers to each types (i.e. fire, water etc.)
There are only 20-21 types i think thus it will return undefined for more than that.
This issue is because someone created a PR for showing Strong Against and Weak Against types and I unknowingly merged it.
from pokedex.
Thankyou so much
i'll probably work on this in evening, currently in office!
from pokedex.
Related Issues (20)
- i can add pokemonball in navbar redesign the nav HOT 1
- Incorrect Topic HOT 2
- Organized files(css, js) inside folder HOT 2
- Redesigning the search bar HOT 5
- Adding a filter by section HOT 2
- Improving the Hover Effect of Types HOT 1
- Add new feature called weak against and strong against below stats in details.html HOT 5
- No favicon icon on the website HOT 2
- Fix: pokemon image not showing HOT 2
- Alignment is getting distorted while searching. HOT 2
- Adding Dark mode HOT 1
- fix taskbar and API call HOT 4
- Search bar text not disappearing on select
- Improvement in dark theme HOT 1
- spinning effect on pokeball HOT 2
- Pull Request Template
- Mobile issue HOT 1
- Upgraded Dark theme
- Text from back side of card visible on mobile HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pokedex.