Comments (5)
that's a great suggestion I hadn't thought about, since I don't use containers extensively. since its a mozilla addon, I do think its worth supporting.
There's a couple design options so far:
-
australis/quantum style tabs of container colored stripe on bottom + static stripe on top
its not the prettiest with the colors clashing but this stays true to the old design
per https://blog.mozilla.org/security/2020/02/06/multi-account-containers-sync/ -
make top and bottom stripes dynamic based on container color
this is the option im leaning towards, as it keeps the same style as 1, but with more consistent color choice -
full border around selected tab
im not the biggest fan of this, since its a bit too prominent on the UI
from firefox-proton-square.
variation on 2 with a 1px height
from firefox-proton-square.
Personally I think either of 1 or 2 would probably be ideal, but don't strongly care which ended up being final because both address the issue and beyond that point it's mostly preference.
Technically, 1 is more consistent for communicating info to the user - the blue stripe always appears above your active tab and is never any other color, so personally I'd probably do that, but I'm more utilitarian so the potential for color clash doesn't bother me that much (and if it did I could always just adjust my container colors to alleviate the issue).
I would not do 3.
Thanks for the quick experimenting on this by the way, really cool to see, especially since multi-account containers is such a standout feature of Firefox.
from firefox-proton-square.
implemented with #21
from firefox-proton-square.
ended up changing it to 2px on my end since I use containers so frequently and it's a bit more readable at a glance with a bit more thickness, but on the whole this is fantastic thanks much
from firefox-proton-square.
Related Issues (20)
- Thank you so very much
- [ not an issue ] code complexity HOT 2
- Custom Border Radius HOT 1
- Multiple tabs taking up too much space HOT 1
- Tab separators aren't displayed properly on Firefox 108 HOT 4
- Firefox 108 breaks vertical centering of tab contents HOT 1
- Adding an option to hide the Unified Extensions Button HOT 2
- Manage Extension Shortcuts HOT 1
- Add option to change position of "Mute" button on the tab for Waterfox HOT 3
- The way that preferences work has been changed HOT 2
- Tab Dividers Hidden On Hover HOT 3
- Extension Icons appear "pushed down", not centered HOT 4
- Sync avatar is too small by default HOT 1
- Few questions! HOT 5
- Button on Closing Multiple Tabs popup alert invisible. HOT 9
- Option to change just the tab list? HOT 2
- Include this proper fix to rounded window corners in instructions HOT 2
- Add user variable to set padding between tabs HOT 1
- Rounded corners in List All Tabs menu HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from firefox-proton-square.