Giter VIP home page Giter VIP logo

Comments (5)

leadweedy avatar leadweedy commented on September 4, 2024

that's a great suggestion I hadn't thought about, since I don't use containers extensively. since its a mozilla addon, I do think its worth supporting.

There's a couple design options so far:

  1. australis/quantum style tabs of container colored stripe on bottom + static stripe on top
    image
    its not the prettiest with the colors clashing but this stays true to the old design
    image
    per https://blog.mozilla.org/security/2020/02/06/multi-account-containers-sync/

  2. make top and bottom stripes dynamic based on container color
    image
    this is the option im leaning towards, as it keeps the same style as 1, but with more consistent color choice

  3. full border around selected tab
    image
    im not the biggest fan of this, since its a bit too prominent on the UI

from firefox-proton-square.

leadweedy avatar leadweedy commented on September 4, 2024

variation on 2 with a 1px height
image

from firefox-proton-square.

orangeandblack5 avatar orangeandblack5 commented on September 4, 2024

Personally I think either of 1 or 2 would probably be ideal, but don't strongly care which ended up being final because both address the issue and beyond that point it's mostly preference.

Technically, 1 is more consistent for communicating info to the user - the blue stripe always appears above your active tab and is never any other color, so personally I'd probably do that, but I'm more utilitarian so the potential for color clash doesn't bother me that much (and if it did I could always just adjust my container colors to alleviate the issue).

I would not do 3.

Thanks for the quick experimenting on this by the way, really cool to see, especially since multi-account containers is such a standout feature of Firefox.

from firefox-proton-square.

leadweedy avatar leadweedy commented on September 4, 2024

implemented with #21

from firefox-proton-square.

orangeandblack5 avatar orangeandblack5 commented on September 4, 2024

ended up changing it to 2px on my end since I use containers so frequently and it's a bit more readable at a glance with a bit more thickness, but on the whole this is fantastic thanks much

from firefox-proton-square.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.