Comments (5)
victhevenot
commented on July 20, 2024
Hey @deniznida - I'm not sure what version of the lab you're looking at, but we removed the dalmatian reference because students haven't learned views in sinatra yet.
Also, in Sinatra you don't use the .html file extension, you can check out the docs on Sinatra templating languages here
Im going to go ahead and close this!
from sinatra-mvc-file-structure.
deniznida
commented on July 20, 2024
@vicfriedman you are right about the .html, the only issue with that is we show our students always .html.erb where we also should tell them that the .html is not necessary in Sinatra.
when I opened this issue the dalmatian reference was still there...
Thanks for looking into this...
from sinatra-mvc-file-structure.
victhevenot
commented on July 20, 2024
hey @deniznida
the readme specially addresses the .html issue:
views directory
This directory holds the code that will be displayed in the browser. In a Sinatra app we use .erb files instead of .html files because .erb files allow us to include regular, old HTML tags AND special erb tags which contain Ruby code. We can name them anything we like, but by convention, our file names will match up with the action that renders them. For example, a GET request to / typically renders a file called index.erb.
can you take at the version of the lab your or your students are using about dalmations? I want to make sure all is resolved!
from sinatra-mvc-file-structure.
deniznida
commented on July 20, 2024
@vicfriedman my classes repo looks good now. We deployed this lab definitely after you fixed the specs. I don't know what happened but its all good now. Thanks
from sinatra-mvc-file-structure.
victhevenot
commented on July 20, 2024
awesome! thanks @deniznida
from sinatra-mvc-file-structure.
Related Issues (15)
- needs content HOT 2
- Test output changes each time rspec is run
- RPEC test inconsistent HOT 3
- rake (loadError) - Is this an error from my environment or part of the lesson to solve? HOT 3
- Dogs tests not hinted at or explained at all in the README.md HOT 3
- DOG? HOT 2
- Tests fail if first defined test does not run first HOT 2
- Verify accuracy of Gemfile.lock description HOT 1
- This lab is SO GOOD. HOT 1
- There's a test missing in the spec/controllers/application_controller_spec.rb file. HOT 1
- Include Sample App Code HOT 1
- Lag HOT 1
- a little unclear HOT 2
- Refers to controller action that hasn't been mentioned yet. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sinatra-mvc-file-structure.