Comments (12)
I forgot to add that the regression I spotted was the missing transitions when changing items and slides
from inspire.js.
Hi Munter,
Yes, I was thinking about this myself. I read about how to add submodules, but I'm still kinda scared to try it out.
Do you have any example of a repo that uses submodules, so that I can check out how it works when cloning, pulling etc?
Thanks!
from inspire.js.
I actually pull in CSSS as a submodule in One-color.js at /slides/3rdparty/
We use it at lot at work for external dependencies and for our own libs that have been open sourced and moved to github.
The basic concept resembles that os a symlink, but hardcoded to a specific commit on the submodule. So when using submodules you need to manually update your reference to a new version when you update prefixfree. This adds an extra working step, but also helps you remember to test that there are no regressions.
Workflow for committing a submodule version update:
cd submodule/path/ git pull (or checkout specific version) cd root/of/CSSS git commit .gitmodules
You usually need to remember the users of the library that they need to pull in submodules as well:
cd CSSS git submodule update --init
If you ever spot a regression in CSSS caused by something in prefixfree you can fix the bug right there inside your submodule checkout, which I find useful for direct testing without making roundtrips through github to test.
from inspire.js.
Thanks for the explanation!
So it has to be a folder inside each repo, it can't be outside like now, right?
Is there a way to make it work with the current reference?
from inspire.js.
The repo can't track anything outside itself, so no-go on that.
I don't see a way it can work in a way where you can refer to prefixfree outside the CSSS folder and still expect it to work when people clone jsut CSSS.
A simple solution could of course be to check in a copy of prefixfree.min.js inside CSSS and update that when needed. That of course gives you less possibilities to debug.
from inspire.js.
That close button certainly is 'close' to the comment button :)
from inspire.js.
The problem is that I also upload everything to my website, and need it to work both locally, and remotely, and on gh-pages. So, that would be a problem. Now I neatly have a different folder for everything, and it even works on gh-pages, when the other repo has a page too.
I'll think about what I can do. Although I don't think it's that hard to clone the other repo as well. But it could become a hassle once I introduce more dependencies. :(
from inspire.js.
Ha, I know why you clicked the close button. If you post a comment with 6 lines and then click "Comment" and keep your mouse pointer in the same position, after it's posted, your mouse is exactly over "Close issue"!
from inspire.js.
How about putting something in the readme telling people to put the PrefixFree folder below CSSS to get things working ? Not an ideal solution but may save some people a little time in the meanwhile.
from inspire.js.
I really like shavenyaknz idea. Otherwise it might be great to simply add the latest version of prefix-free to CSSS to make morking from the beginning.
from inspire.js.
I request #22 to make prefixfree as submodule and solve it
from inspire.js.
Inspire no longer references anything outside this repo, nor does it reference PrefixFree at all, so I'm gonna go ahead and close this.
from inspire.js.
Related Issues (20)
- Can't navigate in mobile browser HOT 8
- Workflow to quicken development of themes? HOT 2
- Slides with scrollbars are not keyboard accessible
- slideshow doesn't start on firefox 3.6.22 HOT 3
- "Specify a selector with the data-subject attribute"
- Broken link from lea.verou.me
- Broken link for CSSS at your projects list
- Video slide layout overflow HOT 2
- Mobile Safari in iPhone 13 Pro crashes upon loading sometimes HOT 1
- [live-demo] "Open in CodePen" does not take append/prepend into account
- How to run completely locally HOT 2
- nested "delayed" class
- Not clear on how to use `data-steps` attribute on a slide HOT 5
- While switching slides, a clipped slide is visible in top-left corner for a moment. HOT 6
- next/previous don't propagate to projector HOT 1
- proper scaling (images too) HOT 1
- Slide Tiles don't work
- Numbers in corner get confused HOT 3
- Keyboard issues HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inspire.js.