Giter VIP home page Giter VIP logo

Comments (6)

leeoniya avatar leeoniya commented on May 14, 2024

I wish it was a synthetic case - but that's what Prettier outputs in some cases

hmm, nothing pretty about that 🤯

there's likely gonna be a ton of technically-valid-but-breaks-dropcss cases so trying to accommodate what various tools spit out will be an endless game of whack-a-mole.

why not just strip out the whitespace using a regex replace before passing it to dropcss? that's generally my advice in such cases. e.g. https://github.com/leeoniya/dropcss#special--escaped-sequences

from dropcss.

amakhrov avatar amakhrov commented on May 14, 2024

hmmm. unlike the map/undo with regex examples there, I wouldn't be able to undo whitespace stripping.

probably not a big deal though

from dropcss.

leeoniya avatar leeoniya commented on May 14, 2024

lol, why bring back the horror? :D

from dropcss.

amakhrov avatar amakhrov commented on May 14, 2024

I mean - in case it replaced something wrong. Regex is not the best tool for processing html.

Probably better to pre-process it with some html minifier, before calling dropcss

from dropcss.

leeoniya avatar leeoniya commented on May 14, 2024

Probably better to pre-process it with some html minifier, before calling dropcss}

i was gonna suggest this, but that's a big perf hit.

Regex is not the best tool for processing html.

no argument there, but i think </\w+\s+> is gonna be extremely uncommon to match accidentally. i'd take take that risk 100% of the time vs ingesting another depndency and taking a big perf hit, but that's just me.

from dropcss.

amakhrov avatar amakhrov commented on May 14, 2024

Thank you very much for the quick response!

from dropcss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.