Giter VIP home page Giter VIP logo

Comments (5)

leeoniya avatar leeoniya commented on May 23, 2024

this change was intentional to avoid triggering mouse events that uplot listens to while the user interacts with third-party dom elements that are added into .u-over (like an anchored tooltip). it was introduced in bab8c11

you should be able to restore the previous behavior by overriding cursor.bind.* with functions that dont do any event target filtering:

bab8c11#diff-ad6d196bc8d38207d186017fc5c2c52660db3a546ccfdfe167fd7ad0c727cdeeR441-R443

a different, probably better approach is to set css pointer-events: none on the highlight region but keep the grip portion responding to events like normal.

from uplot.

lucianbaciu avatar lucianbaciu commented on May 23, 2024

pointer-events: none could be an option, but I'm not sure if it's possible

image

u-select::before is the blue part. u-select is capturing the event. If I set it as pointer-events: none, the grips (which are children) will be also disabled. If I disable events only in the ::before, the main u-select is eating the event

am I missing something?

from uplot.

leeoniya avatar leeoniya commented on May 23, 2024

ah yeah, i forgot the demo implements the grips as select children. then you're right, you can't use the css strategy.

on("mousedown", sel, e => {
bindMove(e, e => update(lft0 + (e.clientX - x0), wid0));
});
on("mousedown", placeDiv(sel, "u-grip-l"), e => {
bindMove(e, e => update(lft0 + (e.clientX - x0), wid0 - (e.clientX - x0)));
});
on("mousedown", placeDiv(sel, "u-grip-r"), e => {
bindMove(e, e => update(lft0, wid0 + (e.clientX - x0)));
});

from uplot.

leeoniya avatar leeoniya commented on May 23, 2024

i'm leaning towards adding the .u-select into the current filter, since it is also "native" to uPlot, like .u-over. hopefully it doesnt affect perf too much to check against two elements during mousemoves vs just one. in most cases i think we can bypass the check when the select size is 0.

from uplot.

lucianbaciu avatar lucianbaciu commented on May 23, 2024

thank you! I will try

from uplot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.