Comments (6)
noamd-legit
commented on June 23, 2024
Hi @rndmh3ro, thank you for opening this issue.
The test to check if the group is premium checks that the plan is not free, so it shouldn't be the reason for the results you see:
func (c *Client) IsGroupPremium(group *gitlab.Group) bool {
plan, err := c.GroupPlan(group)
if err != nil {
log.Printf("failed to get namespace for group %s %v", group.FullPath, err)
return false
}
return plan != "free"
}
Please provide the error.log and permission.log from the legitify run
from legitify.
rndmh3ro
commented on June 23, 2024
Sure, here they are:
{
"missing_permissions": {},
"skipped_policies": {
"code_review_by_two_members_not_required": {
"repo-azure": "Unmet prerequisite: premium"
},
"code_review_not_required": {
"repo-azure": "Unmet prerequisite: premium"
},
"missing_default_branch_protection": {
"repo-azure": "Unmet prerequisite: premium"
},
"missing_default_branch_protection_force_push": {
"repo-azure": "Unmet prerequisite: premium"
},
"no_signed_commits": {
"repo-azure": "Unmet prerequisite: premium"
},
"repository_allows_committer_approvals_policy": {
"repo-azure": "Unmet prerequisite: premium"
},
"repository_allows_overriding_approvers": {
"repo-azure": "Unmet prerequisite: premium"
},
"repository_dismiss_stale_reviews": {
"repo-azure": "Unmet prerequisite: premium"
},
"repository_require_code_owner_reviews_policy": {
"repo-azure": "Unmet prerequisite: premium"
}
}
}{
"missing_permissions": {},
"skipped_policies": {
"code_review_by_two_members_not_required": {
"repo-azure": "Unmet prerequisite: premium"
},
"code_review_not_required": {
"repo-azure": "Unmet prerequisite: premium"
},
"missing_default_branch_protection": {
"repo-azure": "Unmet prerequisite: premium"
},
"missing_default_branch_protection_force_push": {
"repo-azure": "Unmet prerequisite: premium"
},
"no_signed_commits": {
"repo-azure": "Unmet prerequisite: premium"
},
"repository_allows_committer_approvals_policy": {
"repo-azure": "Unmet prerequisite: premium"
},
"repository_allows_overriding_approvers": {
"repo-azure": "Unmet prerequisite: premium"
},
"repository_dismiss_stale_reviews": {
"repo-azure": "Unmet prerequisite: premium"
},
"repository_require_code_owner_reviews_policy": {
"repo-azure": "Unmet prerequisite: premium"
}
}
2024/01/08 08:57:24 2024/01/08 08:57:24 total entities for namespace repository: 1
2024/01/08 08:57:25 2024/01/08 08:57:25 couldn't find group example-group/subgroup
from legitify.
noamd-legit
commented on June 23, 2024
Thanks!
The error log captures the problem. Since we can find the group, we cant determine if it is premium or not (by default, it is not)
Are you the admin of this group?
Could you add the output this API call:
gitlab_api_endpoint.XX/groups?owned=true
from legitify.
rndmh3ro
commented on June 23, 2024
This is the relevant group. I'm not admin as far as I know. :)
{
"id": 34,
"web_url": "https://git.example.com/groups/example-group",
"name": "example-group",
"path": "example-group",
"description": "",
"visibility": "private",
"share_with_group_lock": false,
"require_two_factor_authentication": false,
"two_factor_grace_period": 48,
"project_creation_level": "developer",
"auto_devops_enabled": null,
"subgroup_creation_level": "owner",
"emails_disabled": false,
"emails_enabled": true,
"mentions_disabled": null,
"lfs_enabled": true,
"default_branch_protection": 2,
"default_branch_protection_defaults": {
"allowed_to_push": [
{
"access_level": 30
}
],
"allow_force_push": true,
"allowed_to_merge": [
{
"access_level": 30
}
]
},
"avatar_url": "https://git.example.com/uploads/-/system/group/avatar/34/example-group.png",
"request_access_enabled": false,
"full_name": "example-group",
"full_path": "example-group",
"created_at": "2019-07-09T10:33:41.438Z",
"parent_id": null,
"shared_runners_setting": "enabled",
"ldap_cn": "----",
"ldap_access": 50,
"ldap_group_links": [
{
"cn": "----",
"group_access": 50,
"provider": "ldapmain",
"filter": null
},
{
"cn": "grp.example-group",
"group_access": 50,
"provider": "ldapmain",
"filter": null
},
{
"cn": "6008-all",
"group_access": 20,
"provider": "ldapmain",
"filter": null
},
{
"cn": null,
"group_access": 20,
"provider": "ldapmain",
"filter": "(cn=fnu-cred-scan)"
},
],
"marked_for_deletion_on": null,
"wiki_access_level": "enabled"
},
``
from legitify.
noamd-legit
commented on June 23, 2024
Thanks. It should be fixed in the main branch :)
from legitify.
rndmh3ro
commented on June 23, 2024
Indeed it is, thanks! :)
from legitify.
Related Issues (20)
- Report Script HOT 1
- Policy Skip Support for GitHub Action HOT 1
- Parameterize output report name in GH action HOT 2
- legitify analyze --repo doesn't support gitlab projects within subgroups HOT 5
- When the "ignore-policies" option is enabled, GitHub Action disregards the "extra" parameter HOT 4
- SARIF format results do no supply the actual violation results? HOT 2
- legitify doesn't support nested GitLab projects completely HOT 8
- "organization_has_too_many_admins" policy doesn't flag an organization with 8 owners HOT 5
- Add the needed permissions/scopes to the custom action documentation HOT 4
- Running the GitHub action with ` scorecard: verbose` fails with error `failed to enrich scorecard: expecting []ScorecardCheck` HOT 1
- Support using legitify action with GITHUB_TOKEN
- 1.0.5 release did not get completed HOT 2
- "Reaching out" Message comes with every usage of legitify convert HOT 1
- Restricting email notifications (GitHub) HOT 2
- Skip evaluating archived GitHub repos in an org HOT 2
- GHA - unable to add extra: --namespace -unknown flag HOT 2
- GitHub Ruleset awareness HOT 1
- Gitlab group license discovery fails with 1.0.8
- Remediation Steps in Output are Formatted as Double Numbered List HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from legitify.