Comments (2)
@fatuhoku I think this is a good idea, but I'd recommend we not change the implementation to ES6 classes yet, and instead just use the mixin version
I'm using ES6 classes almost exclusively now in my React.js projects, but I've seen some general aversion to doing so in the react-native project (for whatever reason), where it seems React.createClass
may still be the preferred method.
This would also have the benefit of not changing so much of the implementation. That said, if I'm wrong about the aversion to ES6 classes, i'm happy to accept that PR as well...
from react-native-parallax-view.
Yep fair enough! I only learned about decorators yesterday so wasn't sure which one to go for. Whichever way makes scrollTo work, basically. I was running into unfamiliar ground using decorators. I'll try out the mix in when I have time.
from react-native-parallax-view.
Related Issues (20)
- status bar overflow
- Does not work with RefreshControl HOT 1
- [android] not working at all HOT 6
- Questions of implementation
- [IOS] not work HOT 3
- Use LinearGradient on image HOT 2
- position background image
- Header props doesn't work regardless of where it is placed
- Option to style window. HOT 1
- Missing prop to style image component. HOT 2
- background image did not get bigger
- [Android] Issue with absolute positioned view in parallax view HOT 2
- header does not show sometimes
- Any way to detect on click on image ? HOT 1
- Undefined is not an object (evaluating React.Proptypes.number) HOT 3
- RN 0.49.3 broken change HOT 2
- Add contributors to the project because it's dead HOT 4
- 请问如何才能让标题图片显示在导航条下面,向上滑动时不会把导航条遮挡 HOT 1
- Error. Cannot read property 'number' of undefined. HOT 8
- How to stop slipping when internal drag & sort component dragging
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-parallax-view.