Giter VIP home page Giter VIP logo

Comments (2)

lelandrichardson avatar lelandrichardson commented on July 3, 2024

@fatuhoku I think this is a good idea, but I'd recommend we not change the implementation to ES6 classes yet, and instead just use the mixin version

I'm using ES6 classes almost exclusively now in my React.js projects, but I've seen some general aversion to doing so in the react-native project (for whatever reason), where it seems React.createClass may still be the preferred method.

This would also have the benefit of not changing so much of the implementation. That said, if I'm wrong about the aversion to ES6 classes, i'm happy to accept that PR as well...

from react-native-parallax-view.

fatuhoku avatar fatuhoku commented on July 3, 2024

Yep fair enough! I only learned about decorators yesterday so wasn't sure which one to go for. Whichever way makes scrollTo work, basically. I was running into unfamiliar ground using decorators. I'll try out the mix in when I have time.

from react-native-parallax-view.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.