Giter VIP home page Giter VIP logo

Comments (3)

lelandrichardson avatar lelandrichardson commented on July 23, 2024

What version of RN are you using? I've noticed the performance has varied a bit by version, though I'm not sure why.

I am going to push a fix soon that just uses setNativeProps inside of requestAnimationFrame and I think that that should bring essentially optimal performance.

Thanks

from react-native-parallax-view.

deanmcpherson avatar deanmcpherson commented on July 23, 2024

@lelandrichardson I have been having a play with implementing the above in requestAnimationFrame, but I think it's probably best to keep the setNativeProps in the onScroll callback, as the scroll position will only be updated then anyway (unless you're going to lookup the current scroll position outside of the event? Not sure how that works).

Best performance I've seen so far is using setNativeProps as implemented (commented out in ParallaxView.js) and dropping the scrollEventThrottle to 10 as opposed to 16. I figure 16ms is a 60fps frame, but it will optimistically take a couple of milliseconds to be rendered.

from react-native-parallax-view.

lelandrichardson avatar lelandrichardson commented on July 23, 2024

@deanmcpherson Interesting approach using 10ms as opposed to 16... I tried using requestAnimationFrame a couple of different ways and never had great luck. As a result, I've moved the entire component to use the new Animated API which has considerably better performance. This update is now on NPM with version number 2.0. As a result, i'm closing this issue...

from react-native-parallax-view.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.