How to contribute about pglast HOT 4 CLOSED

That's great, thank you!

I know that lots of nodes are missing, but given the impressive number of them, I think the most viable way is to add them as the need arise... I could not find a comprehensive collection of all possible statements. BTW, how are the "regression tests" you mention written? Could you point me there?

Wrt contributing back, I'm fine with a single PR, as long as there are tests against all added nodes, keeping test coverage as close to 100% as possible. That basically means adding SQL statements to tests/test_d?l_printers.py (for example, in tests/test_dml_printers.py there's a SELECTS multiline string, with SQL statements separated by an empty line...) asserting that all the nodes get exercized.

Cannot promise on when I can do that, but I'm willing to take care of the prettification of the new nodes.

About the "printer overrides", that should be properly integrated, if possible.

Let me know if you need further advice!

from pglast.

Thank you, I will try to do that as soon as possible, hopefully this week.

The regression tests for PostgreSQL are mostly here: https://git.postgresql.org/gitweb/?p=postgresql.git;a=tree;f=src/test/regress/sql;h=381270746f8f42574dedd946c190e6a1be89d4ee;hb=HEAD

They consist in a set of sql file, each associated with an expected output. I think this makes for a great reference of which features are supported or not, since they should exercise every possible statement (in theory, I don't know the exact coverage though).

from pglast.

I could not find a comprehensive collection of all possible statements.

This isn't specific to postgres, but it might be useful: BNF Grammars for SQL-92, SQL-99 and SQL-2003

from pglast.

This has been released as of version 1.3. Thank you!

from pglast.