[Bug]: Building `console` feature requires `tokio_unstable` rustflag, panics otherwise about lemmy HOT 7 CLOSED

You might already be aware of this but I couldn't find any note or discussion, so this is here at least for posterity's sake.

I do wonder though why it even compiled, would have expected this to pop up sooner (but I don't know anything about tokio or rustflags).

from lemmy.

Right you need to set the mentioned env var, Im adding a comment. Here the documentation.

from lemmy.

Yeah, I also added RUSTFLAGS= (empty by default) into the Dockerfile so that this can be propagated from build-args, I could PR that if you want.

from lemmy.

Yes sure.

from lemmy.

fwiw putting the opentelemetry stuff behind the console feature doesn't make a lot of sense. Even though they both rely on tracing, they are different things and serve different purposes

from lemmy.

have been digging into this whole thing for last few hours and there seem to be two other problems (I might be blind though):

Minor thing: when enabling OTLP tracing, you have to set RUST_LOG to more verbose values as it also filters out what is sent to the trace consumer (jaeger), this in turn makes console output too verbose (with stuff that I am already getting in the consumer).
Adding some kind of opentelemetry_log field into the config to control this separately would be nice.
The code in question.

Bigger thing: HTTP Tracing across services does not work.
The incoming trace_id is ignored (proxy sets uber-trace-id header, https://docs.rs/tracing-actix-web/latest/tracing_actix_web/#trace-id, not yet sure how to apply this in root_span_builder - for now I just enabled "tracing-actix-web/opentelemetry_0_16" feature, I am probably missing something).
Requests to pict-rs should also pass the trace id, haven't checked it yet but jaeger does not show connections between lemmy and pict-rs so it's probably also not configured in reqwest(-tracing) (?)

EDIT: I wasn't able to resolve the above issue with trace_ids. The problem is definitely somewhere in

from lemmy.

Im not familiar with any of this stuff, improvements welcome!

from lemmy.