Add FreeBSD support about clifm HOT 8 CLOSED

Though I couldn't use the --author function

I've never used it on GitHub myself as well, but you might want to find this guide and this one with more elaborate animation helpful.

from clifm.

That's great news! Thanks @danfe! As to the patch, consider it done. Just give me a few days.

from clifm.

As to the patch, consider it done. Just give me a few days.

Take your time, there's no rush. You'd most likely want to adjust the patch, as I've only tested in on FreeBSD and wanted to have minimal diff, e.g. the int j variable would be unused in Linux case, and you'd probably want to insert a blank line before if (!self || sysctl(mib, 4, self, &len, NULL, 0) == -1) { and adjust the comment Update filesystem counter ... -> Update mountpoint counter ....

from clifm.

Are you sure you don't want to submit this patch yourself via a PR so that you appear as a contributor to the project? I think that would be fair.

Btw, the patch works ok.

Have you had some issue with the makefile? I modified a few things and now it complains about libintl.h not being found.

UPDATE: The problem was CFLAGS. It seems that FreeBSD has some predefined value for this variable (-O2 -pipe), so that setting it in the makefile using ?= won't work. Should I use += in this case instead?

from clifm.

Are you sure you don't want to submit this patch yourself via a PR so that you appear as a contributor to the project?

I'm not very comfortable with pull requests, and I'm usually not hunting for extra attribution either, just for better code, but I reckon git commit has this --author switch which should DTRT, no?

Should I use += in this case instead?

In the FreeBSD port, I patch the src/Makefile to amend the CFLAGS with += rather than set it, not just because our framework provides default value for it which ports should respect, but also because it's a common build environment variable which better not be overwritten unless there's a strong reason to do so; e.g. -march=native is typically what should IMHO be left to user's discretion.

from clifm.

Ah, forgot to comment about headers not being found. In FreeBSD, third-party software bits are installed under /usr/local prefix, so that's why we have this USES+=localbase thing which adds -isystem /usr/local/include to CFLAGS (and -L/usr/local/lib to LDFLAGS). Another reason to respect, i.e. not trying to override them. ;-)

from clifm.

Great. I'll try the --author option then. Good to know about how FreeBSD handles these make flags. Thanks.

from clifm.

Patch applied and submitted. Though I couldn't use the --author function, I'll mention you in the changelog. Thanks again @danfe!

from clifm.