Clicking noise in production build of 1.0.0 about react-sound HOT 9 CLOSED

Fixed and published in https://github.com/leoasis/react-sound/releases/tag/v1.1.0, let me know if this is all ok now! Thanks for filing the issue and the example!

from react-sound.

Yeah it seems to be fixed now. Thanks for the help.

from react-sound.

Can you provide a repository with the code so that I can repro the issue? Or maybe something like a link in codesandbox or somewhere where I can run the code and see what's going on.

from react-sound.

I'm experiencing the same issue after updating to 1.0.0. Looking at the console, it switches position to 0 after every update, abruptly stopping and resuming. I'm using react-sound as a controlled component. Values I'm updating the prop "position" with are in blue:

I have to revert to 0.8.0.

from react-sound.

Reverting to 0.10.0 also works. The issue disappears if I stop updating position manually. There might be a problem with how the position state is updated internally in react-sound.

from react-sound.

@nukeop can you provide a quick repro snippet so I can take a look? Can be a repo, a codesandbox link, or any other thing that I can go and install/use

from react-sound.

I'll try to throw something together later today (I encountered the issue in the music player I'm working on but I doubt you want to download the entire program just to check this issue).

Anyway I'm positive that this isn't a problem on my end as I tried the same steps with react-sound 1.0.0 and 0.10.0 and only saw this happening only with 1.0.0.

from react-sound.

Thanks! I'm willing to fix whatever is broken but just want to have a way to repro it in a somewhat easy way

from react-sound.

https://github.com/nukeop/sound-bug

Clone, npm install, npm run dev, and go to localhost:8080 to see the problem

After changing react-sound to 0.10.0 in package json, npm install again and run it to see the problem disappear.

from react-sound.