Comments (2)
@alexedwards I've been looking into this issue, and while it's a bug, the solution is more complex than just N=1.
What's happening here is that the Locale
object you're using doesn't have the Domain (Po
object) you're requesting loaded, so it defaulted to the plural.
That said, the current implementation was using the n == 1
rule to identify singular cases, and that's kind of incorrect, because it would depend on the plurals definition from the .po file.
So I'm working on a solution in the Po
object that will fallback to the corresponding default value based on the plural forms definitions in the .po file.
When it fallbacks to an non-existing translation string, but on an existing domain (.po file) it will use this new approach.
Otherwise, as if the domain isn't loaded and it doesn't knows how plural definitions are, it will fallback using the western n == 1
rule, just to make a convention here.
I'll be pushing a fix to master branch soon.
from gotext.
Thanks for the time looking into this and the fast fix. I really appreciate it 👍
from gotext.
Related Issues (20)
- plurals subpackage appears to plagiarise github.com/ojii/gettext.go/pluralforms HOT 3
- Please add cli/xgotext to v1.4.1 HOT 3
- Project status and feature request to use embed po files HOT 7
- xgotext performance
- v1.5.0 is a breaking change HOT 3
- Get and similar functions don't always process formatting sequences HOT 1
- Keep order in po files HOT 4
- xgotext emits backtick-delimited strings into .pot files
- Exported strings can break PO file format
- Missing support for fallback translations HOT 3
- Add support for json format HOT 1
- Locale should expand the string to include country code if necessary HOT 1
- `Get("")` is returning all headers HOT 4
- expose lang from Locale HOT 2
- can we have pseudo locale support ? HOT 5
- documentation on usage with templates? HOT 3
- Multi-line and backquotes strings support incorrect compared to gettext spec
- Plurals export into po file HOT 2
- Properly tag the latest release HOT 1
- Bug in IsTranslatedN() HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gotext.