Giter VIP home page Giter VIP logo

Comments (7)

Neohiro79 avatar Neohiro79 commented on June 5, 2024

To be more precise here, this is an example (.less File)

// disables the whole ruleset, just because it's // instead of /**/
h1 {
        font-size: 20px; /* works, when above // is changed into normal css-comments */
        /*
               // color: #FFFFFF;
        */
        background-color: #000000; /* rule does not work, once the above comment is // only */
}

from less.js.

Neohiro79 avatar Neohiro79 commented on June 5, 2024

Sorry, problem solved, since everything else less normally offers also didn't work either with that specific file I got suspicious.

If anybody has had the same problem, make sure you include the .less file as
link rel="stylesheet/less"
since the less-parser actually won't trigger a warning or error of a false less-type include.

I recently renamed a .css into a .less file and also included the less-parser properly, which went through without any errors, so I didn't catch the problem firsthand.

So, here is a feature request:
Since it's really hard to get even find a problem firsthand or get to the problem in this case, is there a way the less-parser can detect a wrongly embedded less-filetype (ie. get link rel content via JS and compare if "stylesheet/less" is correctly placed and triggers a fat warning, since sometimes one just forgets to change this type when including more than one .less file in a document?

from less.js.

Cyddharth-Gupta avatar Cyddharth-Gupta commented on June 5, 2024

@Neohiro79 i guess the problem is resolved please close the issue.

from less.js.

Neohiro79 avatar Neohiro79 commented on June 5, 2024

So, there is no thought or comment on my follow-up feature-request to make the less-parser detect a potentially wrongly embedded less-filetype through ie.

var styleSheetList = document.styleSheets;

then comparing the suffix of the filename

if (".less" file && if "text/less") { fine } else { trigger additional warning into console } ?

from less.js.

Cyddharth-Gupta avatar Cyddharth-Gupta commented on June 5, 2024

@Neohiro79 my apologies, missed a couple of lines, thought the issue to be resolved

from less.js.

Neohiro79 avatar Neohiro79 commented on June 5, 2024

@Cyddharth-Gupta No problem - I just thought that it would make sense after I discovered that a google search completely mislead me to find/locate this error which took me some hours. It get's "parsed" without an error, in case you include a .less file but with text/css inside the rel attribute.

Also, additional to my proposal there should be also the opposite case covered (ie. ".css" is there but "text/less" is the rel/type value):

if (".css" file-suffix && "text/less") { fine } else { trigger additional warning into console }

and also in case ".less" is there but only "text/css" is written in the rel/type-attribute:

if (".less" file-suffix && "text/css") { trigger additional warning into console } else { fine }

That would cover the basic pitfalls which can always happen when including more than one file (or even in case you just don't know or forgot)

from less.js.

matthew-dean avatar matthew-dean commented on June 5, 2024

In web requests, a file extension cannot actually tell you what type of file it is, because you can easily set up something like a .php file that provides the appropriate content and headers for a particular file type. So you need a way to signal, in your markup, what type you expect. Adding a warning in those cases would just possibly add a bunch of noise to the console.

from less.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.