Replace "HTTP Generic" with "HTTP Generic Advanced" Controller about espeasy HOT 13 CLOSED

So for realy generic - template per sensortype feature is also needed.

from espeasy.

sounds good krikk:)

from espeasy.

TODO: an option to send all the values in one http request?

from espeasy.

that last pull request is pretty good. now we can send multiple values in one call, and prevent needing a new controller for things like the nettemp one.

i did a bit of cleaning up and added it to testing.

a few notes for improvements:

• the big complex whileloops that delete unused variables should just call a generic function, like this: void DeleteVarIndex(String &s, byte varindex).

In case of SENSOR_TYPE_SINGLE you can then just call:
DeleteVarIndex(s, 2);
DeleteVarIndex(s, 3);
DeleteVarIndex(s, 4);

• handling of special stuff like SENSOR_TYPE_LONG should also be done in ReplaceTokenByValue(). That way we can remove the whole switch-statement in "case CPLUGIN_PROTOCOL_SEND:" and simply call HTTPSend011().

In the future we then can also add more complex stuff like wind-direction strings.

After that there is more room for little improvements, making the code even smaller and better maintainable. :)

thanks for all the hard work!

from espeasy.

OK, need to add also custom server key:
&key=SomeKey
and actual esp-ip-address:
&ip=1.1.1.1

for gpio have different template - will be possible to store it as different Controller?

Maybe it is good idea to hardcode some tamplates in HTTP Generic Advenced - to easy choose from?

from espeasy.

the key should be no problem you can add what ever text you want... the ip is also possible with %ip% after my newest pull requst is merged...

from espeasy.

from espeasy.

in a first step i will be simplier to collect this templates on the wiki...

from espeasy.

indeed. later i want to make a piece of javascript that dynamicly loads the templates from github. so we can add templates on the fly without needing new and bigger firmware.

i'm doing a similar thing for my ledanim project. works great.

from espeasy.

@psy0rz nice project :)

from espeasy.

would be nice to add a "PATCH" method to HTTP Generic advanced

from espeasy.

PATCH method?

from espeasy.

@krikk Yes! Currently supported is GET,POST,PUT and HEAD - to update variables in pimatic via restAPI PATCH is needed

from espeasy.