Giter VIP home page Giter VIP logo

Comments (8)

jsha avatar jsha commented on May 17, 2024

Update on this:

  • According to the spec, /new-cert should return the new certificate in its body, in addition to a Location header pointing to the canonical URL for the new certificate. The identifying part of the canonical URL is not specified: an obvious choice would be serial number.
  • We probably want to modify the spec so the client requests a new cert and then polls until it's ready. This allows us to deal with a few things:
    • Ensuring the first OCSP "valid" response is signed and push to the origin server for OCSP responses.
    • It's possible the CA may lag behind during times of heavy load, and we might have to wait a moderate amount of time for the certificate to be generated.
    • The longer we hold a request open the more likely it is to get reset by random network issues. We should, relatedly, figure out what the client should do if it makes a certificate request but gets a network failure before seeing a response.

from boulder.

jsha avatar jsha commented on May 17, 2024

For now I think it's fine to proceed with coding the client to expect a certificate directly in the body of the /new-cert response. @jdkasten

from boulder.

jdkasten avatar jdkasten commented on May 17, 2024

Thanks, @jsha! cc @kuba @garrettr

On Wed, Apr 1, 2015 at 4:45 PM, jsha [email protected] wrote:

For now I think it's fine to proceed with coding the client to expect a
certificate directly in the body of the /new-cert response. @jdkasten
https://github.com/jdkasten


Reply to this email directly or view it on GitHub
#72 (comment).

from boulder.

jsha avatar jsha commented on May 17, 2024

Actually I'm not sure how I missed it but it looks like the current code does provide the Location header pointing to the new cert. Was this not showing up in your tests?

from boulder.

jdkasten avatar jdkasten commented on May 17, 2024

All of my info is probably outdated at this point. I have been trying to work on other aspects of the project. I stopped working on trying to get integration when the deadline was moved (local testing mode was still hardcoded). At the time I didn't write any reoccuring tests against Boulder because my solution was a hack (deadline) and it also requires authorization which was difficult to come by. @kuba or @GarettR probably know the most right now regarding protocol violations. @kuba wrote networking code and an example script to test the server here restified.py It just doesn't achieve authorization as that requires full client integration. I know he listed current problems with Boulder/spec as TODOs in the network2 code that I can forward to you if it would help.

from boulder.

jdkasten avatar jdkasten commented on May 17, 2024

Here is @kuba's restified networking code. It references Boulder throughout... but it hasn't been integrated into mainline client yet.

https://github.com/letsencrypt/lets-encrypt-preview/blob/master/letsencrypt/client/network2.py

from boulder.

kuba avatar kuba commented on May 17, 2024

network2 actually expects POST /new-cert to return DER-encoded certificate in the HTTP response body and Location header set to the Certificate Resource URI (and optionally "up" Link header poiting at chain certificate URL). It wasn't easy to derive that this is the intended behavior, but I believe it follows logically from the spec.

from boulder.

pde avatar pde commented on May 17, 2024

Working as intended.

from boulder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.