Giter VIP home page Giter VIP logo

Comments (2)

cpu avatar cpu commented on June 1, 2024

@marsangr That sounds good 👍. The URL scheme should be populated from the request protocol.

from pebble.

cpu avatar cpu commented on June 1, 2024

Hi @marsangr,

Revisiting this issue I realize what I thought would be an acceptable fix (populating the expectedURL.Scheme based on the request.Proto or request.TLS state) won't work for the scenario you describe where TLS is terminated by another daemon and Pebble remains running on HTTP.

I'd suggest just allowing for both schemes in the url parameter of the JWS header

I think this sort of flexibility is the wrong approach - we don't want requests authenticated by a client expecting it was talking to an HTTPS service to be replayable against the same endpoint on HTTP.

I think a better approach is to drop HTTP support and make Pebble operate on HTTPS by default. I've opened an issue (#63) for a simple implementation using MiniCA. I'm going to close this issue in favour of 63. Thanks!

from pebble.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.