Upgrade to Rust nightly about lettre HOT 7 CLOSED

I'm just curious: Why are you rewriting every to_string() with the format! macro? Is this considered to be a best practice?

from lettre.

The reason I did it was because to_string() no longer wanted to compile. Maybe it was some kind of glitch and it works again, or maybe it was just removed from Prelude and should have been imported explicitly.

And yes, AFAIK, format! is the way to go.
to_string() is implemented as (a variation of) format! - http://doc.rust-lang.org/src/collections/string.rs.html#937-946

from lettre.

Thanks for that information @ArtemGr

from lettre.

NB, for strings format! is temporarily slower than String::from_str, rust-lang/rust#20400

from lettre.

FYI, an updated patch landed at https://github.com/ArtemGr/rust-smtp/commit/aaf2147117da119fba87986e10ea012d9fe6c74c

from lettre.

Merged, thank you. I am updating the tests.

from lettre.

Cool! )

BTW, I'm not sure if the features vector will be formatted correctly, had to use the {:?} as a quick fix because it wouldn't format with {} for some reason.

from lettre.