Memory leak about lettuce-core HOT 6 CLOSED

The problem seems to be with PubSubCommandHandler.decode() which never discards of read bytes in the buffer. It override the method that calls buffer.discardReadBytes() in CommandHandler but never calls buffer.discardReadBytes() itself. This means the buffer will keep growing forever while receiving messages from channel subscription.

Another oddity I found is that the connection is never closed on exception. Even if RedisStateMachine.decode() throws IllegalStateException the connection keeps going. Resetting the connection on unknown exceptions would have at least cleared the buffer in this case and let the application keep running, assuming the connection watchdog is enabled.

from lettuce-core.

Thanks for the memory leak fix. I'll make up my mind about exceptions on connections and the result of exceptions on the whole state.

from lettuce-core.

Thanks!

from lettuce-core.

Released lettuce 3.0.2.Final to maven central.

from lettuce-core.

Thx. An experimental feature could be close connection on internal errors, as you mentioned it. Will track it in #25

from lettuce-core.

I found a better approach than closing the connection: Resetting the internal state. I updated #25 accordingly.

from lettuce-core.